Moodle
  1. Moodle
  2. MDL-38745

SCORM API Debugging: appending 'API logging is on|off', once per activity launch

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.3
    • Fix Version/s: 2.5
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide

      (Difficulty: easy, requires both (server) administrator access, to cleanup JS caching, and teacher access to a course)

      1. Apply the patch and cleanup the JS cache in the dataroot e.g. rm /path/to/moodle-master-data/cache/js/*
      2. Open a browser and cleanup its cache
      3. Log as Administrator and activate SCORM API Debugging
      4. Log into a Course, e.g. a Topics one, and Turn Editing on.
      5. Create a new SCORM activity using the Prodding SCO (© 2007 Claude Ostyn), SCORM 1.2, e.g. DnD the file into a Topic.
      6. Click on this new SCORM activity and attend to it: a new popup|tab will be opened too (the SCORM API Activity Log)
      7. The item will be launched: the Prodding SCO will appear
      8. Click on the link to "SCORM Diagnostic SCO" in the TOC to reload the SCO in the main window
      9. make sure the link "API logging is on" is only displayed once
      10. Click on the link to "SCORM Diagnostic SCO" again in the TOC to reload the SCO in the main window
      11. make sure the link "API logging is on" is only displayed once
      Show
      (Difficulty: easy, requires both (server) administrator access, to cleanup JS caching, and teacher access to a course) Apply the patch and cleanup the JS cache in the dataroot e.g. rm /path/to/moodle-master-data/cache/js/* Open a browser and cleanup its cache Log as Administrator and activate SCORM API Debugging Log into a Course, e.g. a Topics one, and Turn Editing on. Create a new SCORM activity using the Prodding SCO (© 2007 Claude Ostyn), SCORM 1.2 , e.g. DnD the file into a Topic. Click on this new SCORM activity and attend to it: a new popup|tab will be opened too (the SCORM API Activity Log ) The item will be launched: the Prodding SCO will appear Click on the link to "SCORM Diagnostic SCO" in the TOC to reload the SCO in the main window make sure the link "API logging is on" is only displayed once Click on the link to "SCORM Diagnostic SCO" again in the TOC to reload the SCO in the main window make sure the link "API logging is on" is only displayed once
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      m25_MDL-38745_SCORM_API_Debugging_trivial_issue
    • Rank:
      48803

      Description

      When SCORM API Debugging is enabled "API logging is on" is appended on top of the main SCORM window, just above the TOC to allow you to selectively (per user, cookie persistent) disable that feature.
      That statement is appended each time you launch the item.

      Found when working at MDL-38678.

        Issue Links

          Activity

          Hide
          Dan Marsden added a comment -

          looks good - bouncing up for integration - thanks Matteo

          Show
          Dan Marsden added a comment - looks good - bouncing up for integration - thanks Matteo
          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          Thanks!

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
          Hide
          Matteo Scaramuccia added a comment -

          Rebased.

          Show
          Matteo Scaramuccia added a comment - Rebased.
          Hide
          Aparup Banerjee added a comment -

          thanks, that integrated into master now.

          Show
          Aparup Banerjee added a comment - thanks, that integrated into master now.
          Hide
          Rossiani Wijaya added a comment -

          Hi Matt,

          For step 12, I can't get the "Item ITEM1 has been defined as an Asset: it should never call the SCORM API" message on my log.

          SCORM API Activity Log
          Thu, 04 Apr 2013 05:35:23 GMT: Moodle SCORM 1.2 API Loaded, Activity: dnd scorm, SCO: ITEM1
          Thu, 04 Apr 2013 05:36:02 GMT: LMSInitialize("", "") => 0
          Thu, 04 Apr 2013 05:36:08 GMT: LMSSetValue("cmi.core.session_time", "0000:00:05.35") => 0
          Thu, 04 Apr 2013 05:36:16 GMT: LMSFinish("AJAXResult", "true") => 0
          Thu, 04 Apr 2013 05:36:16 GMT: LMSFinish("result", "true") => 0
          Thu, 04 Apr 2013 05:36:16 GMT: LMSFinish("", "") => 0
          Thu, 04 Apr 2013 05:36:33 GMT: LMSInitialize("", "") => 0
          Thu, 04 Apr 2013 05:36:35 GMT: LMSSetValue("cmi.core.session_time", "0000:00:02.29") => 0
          Thu, 04 Apr 2013 05:36:36 GMT: LMSFinish("AJAXResult", "true") => 0
          Thu, 04 Apr 2013 05:36:36 GMT: LMSFinish("result", "true") => 0
          Thu, 04 Apr 2013 05:36:36 GMT: LMSFinish("", "") => 0
          Thu, 04 Apr 2013 05:37:28 GMT: LMSInitialize("", "") => 0
          Thu, 04 Apr 2013 05:37:30 GMT: LMSSetValue("cmi.core.session_time", "0000:00:01.29") => 0
          Thu, 04 Apr 2013 05:37:31 GMT: LMSFinish("AJAXResult", "true") => 0
          Thu, 04 Apr 2013 05:37:31 GMT: LMSFinish("result", "true") => 0
          Thu, 04 Apr 2013 05:37:31 GMT: LMSFinish("", "") => 0
          

          Could you provide some feedback regarding this?

          Thanks
          Rosie

          Show
          Rossiani Wijaya added a comment - Hi Matt, For step 12, I can't get the "Item ITEM1 has been defined as an Asset: it should never call the SCORM API" message on my log. SCORM API Activity Log Thu, 04 Apr 2013 05:35:23 GMT: Moodle SCORM 1.2 API Loaded, Activity: dnd scorm, SCO: ITEM1 Thu, 04 Apr 2013 05:36:02 GMT: LMSInitialize( "", " ") => 0 Thu, 04 Apr 2013 05:36:08 GMT: LMSSetValue( "cmi.core.session_time" , "0000:00:05.35" ) => 0 Thu, 04 Apr 2013 05:36:16 GMT: LMSFinish( "AJAXResult" , " true " ) => 0 Thu, 04 Apr 2013 05:36:16 GMT: LMSFinish( "result" , " true " ) => 0 Thu, 04 Apr 2013 05:36:16 GMT: LMSFinish( "", " ") => 0 Thu, 04 Apr 2013 05:36:33 GMT: LMSInitialize( "", " ") => 0 Thu, 04 Apr 2013 05:36:35 GMT: LMSSetValue( "cmi.core.session_time" , "0000:00:02.29" ) => 0 Thu, 04 Apr 2013 05:36:36 GMT: LMSFinish( "AJAXResult" , " true " ) => 0 Thu, 04 Apr 2013 05:36:36 GMT: LMSFinish( "result" , " true " ) => 0 Thu, 04 Apr 2013 05:36:36 GMT: LMSFinish( "", " ") => 0 Thu, 04 Apr 2013 05:37:28 GMT: LMSInitialize( "", " ") => 0 Thu, 04 Apr 2013 05:37:30 GMT: LMSSetValue( "cmi.core.session_time" , "0000:00:01.29" ) => 0 Thu, 04 Apr 2013 05:37:31 GMT: LMSFinish( "AJAXResult" , " true " ) => 0 Thu, 04 Apr 2013 05:37:31 GMT: LMSFinish( "result" , " true " ) => 0 Thu, 04 Apr 2013 05:37:31 GMT: LMSFinish( "", " ") => 0 Could you provide some feedback regarding this? Thanks Rosie
          Hide
          Matteo Scaramuccia added a comment -

          Hi Rosie,
          I'll try my evening (CEST time here) and report back.

          Show
          Matteo Scaramuccia added a comment - Hi Rosie, I'll try my evening (CEST time here) and report back.
          Hide
          Dan Marsden added a comment -

          thanks Rosie - I think those testing instructions are incorrect. - will check and fix them

          Show
          Dan Marsden added a comment - thanks Rosie - I think those testing instructions are incorrect. - will check and fix them
          Hide
          Dan Marsden added a comment -

          yeah - completely wrong - it's a copy/paste error sorry.

          Show
          Dan Marsden added a comment - yeah - completely wrong - it's a copy/paste error sorry.
          Hide
          Dan Marsden added a comment -

          fixed the testing instructions now - sorry about that!

          Show
          Dan Marsden added a comment - fixed the testing instructions now - sorry about that!
          Hide
          Rossiani Wijaya added a comment -

          Hi Dan,

          No worries. Thanks for the feedback.

          I retested the issue again and it is working as expected.

          Tested for master only.

          Test passed.

          Show
          Rossiani Wijaya added a comment - Hi Dan, No worries. Thanks for the feedback. I retested the issue again and it is working as expected. Tested for master only. Test passed.
          Hide
          Aparup Banerjee added a comment -

          \o/

          Show
          Aparup Banerjee added a comment - \o/
          Hide
          Matteo Scaramuccia added a comment -

          @Dan: I'm sorry, I've splitted the commits, tested them but not reviewed enough the testing instructions when copied (done after my testing).
          TNX All!

          Show
          Matteo Scaramuccia added a comment - @Dan: I'm sorry, I've splitted the commits, tested them but not reviewed enough the testing instructions when copied (done after my testing). TNX All!
          Hide
          Dan Poltawski added a comment -

          Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

          line 1289 of \lib\changes.php: call to debugging()
          line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
          line 202 of \lib\now.php: call to moodleform->_is_poor_form()
          line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          Show
          Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: