Details

      Description

      To prevent wrong clicks and confusion, the cancel button could have a different style.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Frédéric Massart added a comment - - edited

            Here is patch to make the Cancel button appear differently on the forms. I used bootstrap code to style it. I've also overridden the colours in every theme so that it looks consistent.

            Show
            Frédéric Massart added a comment - - edited Here is patch to make the Cancel button appear differently on the forms. I used bootstrap code to style it. I've also overridden the colours in every theme so that it looks consistent.
            Hide
            Martin Dougiamas added a comment -

            Yes, yes, yes, yes, yes, oh holy flying spaghetti monster, yes. +100

            Show
            Martin Dougiamas added a comment - Yes, yes, yes, yes, yes, oh holy flying spaghetti monster, yes. +100
            Hide
            Damyon Wiese added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            Thanks!

            Show
            Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
            Hide
            Eloy Lafuente (stronk7) added a comment -

            -99, grrr, still Martin wins. Integrated, thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - -99, grrr, still Martin wins. Integrated, thanks!
            Hide
            Rossiani Wijaya added a comment - - edited

            While Testing this on editing role (eg: /integration/master/admin/roles/define.php?action=edit&roleid=1) I noticed the cancel button is not a link because it is using a submit button and name it cancel.

            This is a different issue from Fred's patch. I'm creating new issue to the address this (MDL-38884).

            Show
            Rossiani Wijaya added a comment - - edited While Testing this on editing role (eg: /integration/master/admin/roles/define.php?action=edit&roleid=1) I noticed the cancel button is not a link because it is using a submit button and name it cancel. This is a different issue from Fred's patch. I'm creating new issue to the address this ( MDL-38884 ).
            Hide
            Rossiani Wijaya added a comment -

            Other than the above comment. This is working as expected.

            Test passed.

            Show
            Rossiani Wijaya added a comment - Other than the above comment. This is working as expected. Test passed.
            Hide
            Dan Poltawski added a comment -

            Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

            line 1289 of \lib\changes.php: call to debugging()
            line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
            line 202 of \lib\now.php: call to moodleform->_is_poor_form()
            line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            Show
            Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()
            Hide
            Martin Dougiamas added a comment -

            I've added a link to MDL-38906 as this did not get ported to Bootstrap as well.

            That said, I'm not 100% sure if it's useful there because of the button colouring it has.

            Show
            Martin Dougiamas added a comment - I've added a link to MDL-38906 as this did not get ported to Bootstrap as well. That said, I'm not 100% sure if it's useful there because of the button colouring it has.
            Hide
            Dan Poltawski added a comment -

            Here is a bootstrap ok/cancel where it doesn't look nice (though I don't think its covered by this change anyway)

            Show
            Dan Poltawski added a comment - Here is a bootstrap ok/cancel where it doesn't look nice (though I don't think its covered by this change anyway)

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: