Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38284 META: Improve core JavaScript processes, etc
  3. MDL-38756

YUI_config uses jsrev before it is set during install

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: JavaScript
    • Labels:
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
    • Testing Instructions:
      Hide

      Testing difficulty: medium (requires 2.5dev installation)

      Install a fresh new site using the installation method of existing config.php + no DB + no moodledata:

      • Ensure that jsrev is not set in your config.php, and that:

        $CFG->debug = (E_ALL | E_STRICT);
        $CFG->debugdisplay = true;
        

      • dump your database and moodledata
      • reinstall
      • On the first page of the installation:
        • Confirm that no errors were shown about missing vars

      (you may want to confirm that you do get them without the patch too)

      Show
      Testing difficulty: medium (requires 2.5dev installation) Install a fresh new site using the installation method of existing config.php + no DB + no moodledata: Ensure that jsrev is not set in your config.php, and that: $CFG->debug = (E_ALL | E_STRICT); $CFG->debugdisplay = true; dump your database and moodledata reinstall On the first page of the installation: Confirm that no errors were shown about missing vars (you may want to confirm that you do get them without the patch too)

      Description

      As reported by David Mudrak:

      During install, jsrev is not yet set, and should really not attempt to use the cached copy of the metadata.

      As part of the installation, jsrev is then set to the current timestamp.

      We should therefore check whether jsrev is -1, OR is not set at all.

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Lyons
            Reporter:
            dobedobedoh Andrew Lyons
            Peer reviewer:
            David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
            Integrator:
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Tester:
            Ankit Agarwal Ankit Agarwal
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/May/13