Details

    • Testing Instructions:
      Hide

      Testing difficulty: medium (requires 2.5dev installation)

      Install a fresh new site using the installation method of existing config.php + no DB + no moodledata:

      • Ensure that jsrev is not set in your config.php, and that:
        $CFG->debug = (E_ALL | E_STRICT);
        $CFG->debugdisplay = true;
        
      • dump your database and moodledata
      • reinstall
      • On the first page of the installation:
        • Confirm that no errors were shown about missing vars

      (you may want to confirm that you do get them without the patch too)

      Show
      Testing difficulty: medium (requires 2.5dev installation) Install a fresh new site using the installation method of existing config.php + no DB + no moodledata: Ensure that jsrev is not set in your config.php, and that: $CFG->debug = (E_ALL | E_STRICT); $CFG->debugdisplay = true ; dump your database and moodledata reinstall On the first page of the installation: Confirm that no errors were shown about missing vars (you may want to confirm that you do get them without the patch too)
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
    • Rank:
      48815

      Description

      As reported by David Mudrak:

      During install, jsrev is not yet set, and should really not attempt to use the cached copy of the metadata.

      As part of the installation, jsrev is then set to the current timestamp.

      We should therefore check whether jsrev is -1, OR is not set at all.

        Activity

        Hide
        David Mudrak added a comment -

        +1

        Show
        David Mudrak added a comment - +1
        Hide
        David Mudrak added a comment -

        Submitting for integration on behalf of Andrew. Thanks Andrew for fixing this.

        Show
        David Mudrak added a comment - Submitting for integration on behalf of Andrew. Thanks Andrew for fixing this.
        Hide
        Damyon Wiese added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        Thanks!

        Show
        Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Ankit Agarwal added a comment -

        Tried both cli (install_database.php) and browser install, no errors were seen,
        passing

        Show
        Ankit Agarwal added a comment - Tried both cli (install_database.php) and browser install, no errors were seen, passing
        Hide
        Dan Poltawski added a comment -

        Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

        line 1289 of \lib\changes.php: call to debugging()
        line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
        line 202 of \lib\now.php: call to moodleform->_is_poor_form()
        line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

        Show
        Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: