Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38763

Permission override UI should use JS confirmation

    XMLWordPrintable

Details

    • MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_29_STABLE
    • MOODLE_30_STABLE
    • MDL-38763-master-amd
    • Easy
    • Hide

      Go to any course and in "Course administration -> Users -> Permissions" check that:
      1) Any role capability modification(clicking "+" or "x") leads to JS popup
      2) If you add any role to "Roles with permission" or "Prohibited" for any capability it is saved and persists in database after site refresh
      3) If you remove any role from "Roles with permission" or "Prohibited" for any capability it is saved and persists in database after site refresh

      Test this at not only in course context but also other context that use permission table (admin/roles/permissions.php)

      Show
      Go to any course and in "Course administration -> Users -> Permissions" check that: 1) Any role capability modification(clicking "+" or "x") leads to JS popup 2) If you add any role to "Roles with permission" or "Prohibited" for any capability it is saved and persists in database after site refresh 3) If you remove any role from "Roles with permission" or "Prohibited" for any capability it is saved and persists in database after site refresh Test this at not only in course context but also other context that use permission table (admin/roles/permissions.php)
    • Team Beards Sprint 4, Team Beards Sprint 5, Team Beards Sprint 6
    • Medium

    Description

      I am talking about admin/roles/permissions.php, for example the 'Permissions' like in the quiz or course administration block.

      At the moment, there is one page load to show the 'are you sure' then a second one to acutally perform the action. That is a real pain.

      I think the confirmation when you click the X next to a role name should be JavaScript.

      Similarly, when you click +, the list of role you can add should be in a JS pop-up.

      Attachments

        1. add.png
          add.png
          59 kB
        2. remove.png
          remove.png
          55 kB

        Issue Links

          Activity

            People

              mastnym Martin Mastny
              timhunt Tim Hunt
              John Okely John Okely
              Dan Poltawski Dan Poltawski
              Damyon Wiese Damyon Wiese
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Huong Nguyen, Barbara Ramiro, Bas Brands, Mathew May
              Votes:
              1 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                16/Nov/15