Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38763

Permission override UI should use JS confirmation

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Go to any course and in "Course administration -> Users -> Permissions" check that:
      1) Any role capability modification(clicking "+" or "x") leads to JS popup
      2) If you add any role to "Roles with permission" or "Prohibited" for any capability it is saved and persists in database after site refresh
      3) If you remove any role from "Roles with permission" or "Prohibited" for any capability it is saved and persists in database after site refresh

      Test this at not only in course context but also other context that use permission table (admin/roles/permissions.php)

      Show
      Go to any course and in "Course administration -> Users -> Permissions" check that: 1) Any role capability modification(clicking "+" or "x") leads to JS popup 2) If you add any role to "Roles with permission" or "Prohibited" for any capability it is saved and persists in database after site refresh 3) If you remove any role from "Roles with permission" or "Prohibited" for any capability it is saved and persists in database after site refresh Test this at not only in course context but also other context that use permission table (admin/roles/permissions.php)
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38763-master-amd
    • Sprint:
      Team Beards Sprint 4, Team Beards Sprint 5, Team Beards Sprint 6
    • Issue size:
      Medium

      Description

      I am talking about admin/roles/permissions.php, for example the 'Permissions' like in the quiz or course administration block.

      At the moment, there is one page load to show the 'are you sure' then a second one to acutally perform the action. That is a real pain.

      I think the confirmation when you click the X next to a role name should be JavaScript.

      Similarly, when you click +, the list of role you can add should be in a JS pop-up.

        Attachments

        1. remove.png
          remove.png
          55 kB
        2. add.png
          add.png
          59 kB

          Issue Links

            Activity

              People

              Assignee:
              mastnym Martin Mastny
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              John Okely
              Integrator:
              Dan Poltawski
              Tester:
              Damyon Wiese
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Barbara Ramiro, Bas Brands
              Votes:
              1 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                16/Nov/15