Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38284 META: Improve core JavaScript processes, etc
  3. MDL-38771

$CFG->yuicomboloading prevents use of yui_combo.php

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.3.6
    • Fix Version/s: None
    • Component/s: JavaScript
    • Testing Instructions:
      Hide
      • Disable DEBUG_DEVELOPER
      • In your config.php, set:

        $CFG->yuisplitmodulefiles = true;
        $CFG->yuicomboloading = false;
        

      • Load a page in Moodle
      • Open the dev tools, navigate to the Network tab, and filter on JS/Scripts, clear the list of files loaded so far (if any)
      • Run:

        YUI().use('moodle-course-modchooser');
        

        • Confirm that the paths requested included yui_combo.php
        • *Confirm that they have valid content (e.g. they're not just an error message)
        • Confirm that the content was minified
        • Confirm that each file was loaded separately (e.g. one module per HTTP request)
      • Refresh the page
      • Clear the Network tab again

        YUI().use('charts');
        

        • Confirm that the paths requested included yui_combo.php
        • *Confirm that they have valid content (e.g. they're not just an error message)
        • Confirm that the content was minified
        • Confirm that each file was loaded separately (e.g. one module per HTTP request)
      • Refresh the page
      • Clear the Network tab again
      • Run:

        YUI().use('yui2-graphs');
        

        • Confirm that the paths requested included yui_combo.php
        • *Confirm that they have valid content (e.g. they're not just an error message)
        • Confirm that the content was minified
        • Confirm that each file was loaded separately (e.g. one module per HTTP request)
      • Refresh the page
      • Clear the Network tab again
      • Run:

        YUI().use('gallery-sm-treeview');
        

        • Confirm that the paths requested included yui_combo.php
        • *Confirm that they have valid content (e.g. they're not just an error message)
        • Confirm that the content was minified
        • Confirm that each file was loaded separately (e.g. one module per HTTP request)
      • Set DEBUG_DEVELOPER
      • Refresh the page
      • Clear the Network tab again
      • Run:

        YUI().use('moodle-course-modchooser');
        

        • Confirm that the paths requested included yui_combo.php
        • *Confirm that they have valid content (e.g. they're not just an error message)
        • Confirm that the content was minified
        • Confirm that each file was loaded separately (e.g. one module per HTTP request)
      • Refresh the page
      • Clear the Network tab again
      • Run:

        YUI().use('charts');
        

        • Confirm that the path included yui_combo.php
        • *Confirm that they have valid content (e.g. they're not just an error message)
        • Confirm that the content was not minified
        • Confirm that each file was loaded separately (e.g. one module per HTTP request)
      • Refresh the page
      • Clear the Network tab again
      • Run:

        YUI().use('yui2-graphs');
        

        • Confirm that the path included yui_combo.php
        • *Confirm that they have valid content (e.g. they're not just an error message)
        • Confirm that the content was not minified
        • Confirm that each file was loaded separately (e.g. one module per HTTP request)
      • Refresh the page
      • Clear the Network tab again
      • Run:

        YUI().use('gallery-sm-treeview');
        

        • Confirm that the path included yui_combo.php
        • *Confirm that they have valid content (e.g. they're not just an error message)
        • Confirm that the content was not minified
        • Confirm that each file was loaded separately (e.g. one module per HTTP request)
      • Change your config.php such that:

        $CFG->yuicomboloading = true;
        

      • Re-run the previous test-suite confirming that the setting change has made no difference.
      Show
      Disable DEBUG_DEVELOPER In your config.php, set: $CFG->yuisplitmodulefiles = true; $CFG->yuicomboloading = false; Load a page in Moodle Open the dev tools, navigate to the Network tab, and filter on JS/Scripts, clear the list of files loaded so far (if any) Run: YUI().use('moodle-course-modchooser'); Confirm that the paths requested included yui_combo.php *Confirm that they have valid content (e.g. they're not just an error message) Confirm that the content was minified Confirm that each file was loaded separately (e.g. one module per HTTP request) Refresh the page Clear the Network tab again YUI().use('charts'); Confirm that the paths requested included yui_combo.php *Confirm that they have valid content (e.g. they're not just an error message) Confirm that the content was minified Confirm that each file was loaded separately (e.g. one module per HTTP request) Refresh the page Clear the Network tab again Run: YUI().use('yui2-graphs'); Confirm that the paths requested included yui_combo.php *Confirm that they have valid content (e.g. they're not just an error message) Confirm that the content was minified Confirm that each file was loaded separately (e.g. one module per HTTP request) Refresh the page Clear the Network tab again Run: YUI().use('gallery-sm-treeview'); Confirm that the paths requested included yui_combo.php *Confirm that they have valid content (e.g. they're not just an error message) Confirm that the content was minified Confirm that each file was loaded separately (e.g. one module per HTTP request) Set DEBUG_DEVELOPER Refresh the page Clear the Network tab again Run: YUI().use('moodle-course-modchooser'); Confirm that the paths requested included yui_combo.php *Confirm that they have valid content (e.g. they're not just an error message) Confirm that the content was minified Confirm that each file was loaded separately (e.g. one module per HTTP request) Refresh the page Clear the Network tab again Run: YUI().use('charts'); Confirm that the path included yui_combo.php *Confirm that they have valid content (e.g. they're not just an error message) Confirm that the content was not minified Confirm that each file was loaded separately (e.g. one module per HTTP request) Refresh the page Clear the Network tab again Run: YUI().use('yui2-graphs'); Confirm that the path included yui_combo.php *Confirm that they have valid content (e.g. they're not just an error message) Confirm that the content was not minified Confirm that each file was loaded separately (e.g. one module per HTTP request) Refresh the page Clear the Network tab again Run: YUI().use('gallery-sm-treeview'); Confirm that the path included yui_combo.php *Confirm that they have valid content (e.g. they're not just an error message) Confirm that the content was not minified Confirm that each file was loaded separately (e.g. one module per HTTP request) Change your config.php such that: $CFG->yuicomboloading = true; Re-run the previous test-suite confirming that the setting change has made no difference.
    • Affected Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-38771-master
    • Story Points:
      5

      Description

      It should stop use combo loading, but not yui_combo.php otherwise we have the potential to break caching.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            dobedobedoh Andrew Nicols
            Peer reviewer:
            Petr Skoda
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: