Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Repositories
    • Labels:
    • Testing Instructions:
      Hide

      (difficulty: easy, requires administrator login)

      1. Log into Moodle
      2. Set debugging level, Home ► Site administration ► Development ► Debugging, to DEVELOPER and debugdisplay set to Yes
      3. Click on My Private files, Home ► My profile ► My private files
      4. No warning about the missing of call setType() for 'returnurl' should appear
      Show
      (difficulty: easy, requires administrator login) Log into Moodle Set debugging level, Home ► Site administration ► Development ► Debugging , to DEVELOPER and debugdisplay set to Yes Click on My Private files, Home ► My profile ► My private files No warning about the missing of call setType() for 'returnurl' should appear
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      m25_MDL-38790_Missing_setType_in_My_private_files_form
    • Rank:
      48849

      Description

      Here is the stack of the exceptions shown:

      Did you remember to call setType() for 'returnurl'? Defaulting to PARAM_RAW cleaning.
      line 1275 of \lib\formslib.php: call to debugging()
      line 281 of \lib\formslib.php: call to moodleform->detectMissingSetType()
      line 202 of \lib\formslib.php: call to moodleform->_process_submission()
      line 65 of \user\files.php: call to moodleform->moodleform()
      

      and:

      Did you remember to call setType() for 'returnurl'? Defaulting to PARAM_RAW cleaning.
      line 1275 of \lib\formslib.php: call to debugging()
      line 919 of \lib\formslib.php: call to moodleform->detectMissingSetType()
      line 76 of \user\files.php: call to moodleform->display()
      

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Thanks Matteo, looks good. Sending for integration.

          Show
          Dan Poltawski added a comment - Thanks Matteo, looks good. Sending for integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Hide
          Adrian Greeve added a comment -

          Tested on the master integration branch.
          No warnings found.
          Test passed.

          Show
          Adrian Greeve added a comment - Tested on the master integration branch. No warnings found. Test passed.
          Hide
          Dan Poltawski added a comment -

          Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

          line 1289 of \lib\changes.php: call to debugging()
          line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
          line 202 of \lib\now.php: call to moodleform->_is_poor_form()
          line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          Show
          Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: