Loading...

XML

Word

Printable

Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
https://github.com/scara/moodle.git
Pull Main Branch:
m25_~~MDL-38790~~_Missing_setType_in_My_private_files_form
Pull Main Diff URL:
https://github.com/scara/moodle/commit/0f7d5278162adb91e775b2bb33eae5a4a633354d
Testing Instructions:
Hide

(difficulty: easy, requires administrator login)

Log into Moodle

Set debugging level, Home ► Site administration ► Development ► Debugging, to DEVELOPER and debugdisplay set to Yes

Click on My Private files, Home ► My profile ► My private files

No warning about the missing of call setType() for 'returnurl' should appear
Show
(difficulty: easy, requires administrator login) Log into Moodle Set debugging level, Home ► Site administration ► Development ► Debugging , to DEVELOPER and debugdisplay set to Yes Click on My Private files, Home ► My profile ► My private files No warning about the missing of call setType() for 'returnurl' should appear

Here is the stack of the exceptions shown:

Did you remember to call setType() for 'returnurl'? Defaulting to PARAM_RAW cleaning.

line 1275 of \lib\formslib.php: call to debugging()

line 281 of \lib\formslib.php: call to moodleform->detectMissingSetType()

line 202 of \lib\formslib.php: call to moodleform->_process_submission()

line 65 of \user\files.php: call to moodleform->moodleform()

and:

Did you remember to call setType() for 'returnurl'? Defaulting to PARAM_RAW cleaning.

line 1275 of \lib\formslib.php: call to debugging()

line 919 of \lib\formslib.php: call to moodleform->detectMissingSetType()

line 76 of \user\files.php: call to moodleform->display()

blocks

MDL-38815 Automate MDLQA-1768 - A file can be deleted from file manager.

is duplicated by

MDL-38801 user/files.php sets $data->returnurl without defining in form

Participants:: Adrian Greeve, Dan Poltawski, Eloy Lafuente (stronk7), Matteo Scaramuccia