Moodle
  1. Moodle
  2. MDL-38798

fix compatibility with PHP 5.5beta

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4, 2.5
    • Fix Version/s: 2.4.4, 2.5
    • Component/s: Unit tests
    • Labels:
    • Testing Instructions:
      Hide

      1/ run phpunit tests when using PHP 5.4
      2/ run phpunit tests when using PHP 5.5beta
      3/ try install/upgrade/general use with PHP 5.5beta

      Preferably some developers should switch to 5.5 to prevent any future regressions...

      Show
      1/ run phpunit tests when using PHP 5.4 2/ run phpunit tests when using PHP 5.5beta 3/ try install/upgrade/general use with PHP 5.5beta Preferably some developers should switch to 5.5 to prevent any future regressions...
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w14_MDL-38798_m25_php55

      Description

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Petr Skoda added a comment -

            There were 3 errors:

            1) moodlesimplepie_testcase::test_getfeed
            Undefined property: count

            /Users/skodak/server/workspace/moodle25/lib/filelib.php:3029
            /Users/skodak/server/workspace/moodle25/lib/filelib.php:3214
            /Users/skodak/server/workspace/moodle25/lib/filelib.php:3303
            /Users/skodak/server/workspace/moodle25/lib/simplepie/moodle_simplepie.php:142
            /Users/skodak/server/workspace/moodle25/lib/simplepie/simplepie.class.php:1594
            /Users/skodak/server/workspace/moodle25/lib/simplepie/moodle_simplepie.php:79
            /Users/skodak/server/workspace/moodle25/lib/tests/rsslib_test.php:52
            /Users/skodak/server/workspace/moodle25/lib/phpunit/classes/basic_testcase.php:64

            To re-run:
            vendor/bin/phpunit --colors moodlesimplepie_testcase lib/tests/rsslib_test.php

            2) moodlesimplepie_testcase::test_redirect
            Undefined property: count

            /Users/skodak/server/workspace/moodle25/lib/filelib.php:3029
            /Users/skodak/server/workspace/moodle25/lib/filelib.php:3214
            /Users/skodak/server/workspace/moodle25/lib/filelib.php:3303
            /Users/skodak/server/workspace/moodle25/lib/simplepie/moodle_simplepie.php:142
            /Users/skodak/server/workspace/moodle25/lib/simplepie/simplepie.class.php:1594
            /Users/skodak/server/workspace/moodle25/lib/simplepie/moodle_simplepie.php:79
            /Users/skodak/server/workspace/moodle25/lib/tests/rsslib_test.php:138
            /Users/skodak/server/workspace/moodle25/lib/phpunit/classes/basic_testcase.php:64

            To re-run:
            vendor/bin/phpunit --colors moodlesimplepie_testcase lib/tests/rsslib_test.php

            3) core_course_external_testcase::test_duplicate_course
            coding_exception: Coding error detected, it must be fixed by a programmer: backup_helper::store_backup_file() expects valid $filepath parameter

            /Users/skodak/server/workspace/moodle25/backup/util/helper/backup_helper.class.php:218
            /Users/skodak/server/workspace/moodle25/backup/moodle2/backup_stepslib.php:1638
            /Users/skodak/server/workspace/moodle25/backup/util/plan/backup_execution_step.class.php:34
            /Users/skodak/server/workspace/moodle25/backup/util/plan/base_task.class.php:153
            /Users/skodak/server/workspace/moodle25/backup/util/plan/base_plan.class.php:163
            /Users/skodak/server/workspace/moodle25/backup/util/plan/backup_plan.class.php:110
            /Users/skodak/server/workspace/moodle25/backup/controller/backup_controller.class.php:309
            /Users/skodak/server/workspace/moodle25/course/externallib.php:1042
            /Users/skodak/server/workspace/moodle25/course/tests/externallib_test.php:636
            /Users/skodak/server/workspace/moodle25/lib/phpunit/classes/advanced_testcase.php:76

            To re-run:
            vendor/bin/phpunit --colors core_course_external_testcase course/tests/externallib_test.php

            There was 1 failure:

            1) zip_packer_testcase::test_archive_to_pathname
            Failed asserting that false is true.

            /Users/skodak/server/workspace/moodle25/lib/filestorage/tests/zip_packer_test.php:139
            /Users/skodak/server/workspace/moodle25/lib/phpunit/classes/advanced_testcase.php:76

            To re-run:
            vendor/bin/phpunit --colors zip_packer_testcase lib/filestorage/tests/zip_packer_test.php

            FAILURES!
            Tests: 1714, Assertions: 30465, Failures: 1, Errors: 3, Skipped: 11.
            Potential coding error - existing temptables found when disposing database. Must be dropped!
            PHP Notice: Trying to get property of non-object in /Users/skodak/server/workspace/moodle25/lib/moodlelib.php on line 6743
            PHP Stack trace:
            PHP 1.

            {main}() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:0
            PHP 2. PHPUnit_TextUI_Command::main() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:63
            PHP 3. PHPUnit_TextUI_Command->run() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129
            PHP 4. moodle_database->__destruct() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:0
            PHP 5. pgsql_native_moodle_database->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:146
            PHP 6. moodle_database->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/pgsql_native_moodle_database.php:217
            PHP 7. moodle_temptables->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:352
            PHP 8. database_manager->drop_table() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_temptables.php:131
            PHP 9. ddl_table_missing_exception->__construct() /Users/skodak/server/workspace/moodle25/lib/ddl/database_manager.php:324
            PHP 10. ddl_exception->__construct() /Users/skodak/server/workspace/moodle25/lib/ddllib.php:94
            PHP 11. moodle_exception->__construct() /Users/skodak/server/workspace/moodle25/lib/ddllib.php:81
            PHP 12. core_string_manager->string_exists() /Users/skodak/server/workspace/moodle25/lib/setuplib.php:138
            PHP 13. core_string_manager->load_component_strings() /Users/skodak/server/workspace/moodle25/lib/moodlelib.php:6836

            Notice: Trying to get property of non-object in /Users/skodak/server/workspace/moodle25/lib/moodlelib.php on line 6743

            Call Stack:
            0.0002 227696 1. {main}

            () /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:0
            0.0188 538400 2. PHPUnit_TextUI_Command::main() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:63
            0.0188 539024 3. PHPUnit_TextUI_Command->run() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129
            621.6757 258499376 4. moodle_database->__destruct() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:0
            621.6757 258499376 5. pgsql_native_moodle_database->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:146
            621.6757 258499376 6. moodle_database->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/pgsql_native_moodle_database.php:217
            621.6757 258499648 7. moodle_temptables->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:352
            621.6758 258500976 8. database_manager->drop_table() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_temptables.php:131
            621.6802 258573192 9. ddl_table_missing_exception->__construct() /Users/skodak/server/workspace/moodle25/lib/ddl/database_manager.php:324
            621.6802 258573288 10. ddl_exception->__construct() /Users/skodak/server/workspace/moodle25/lib/ddllib.php:94
            621.6803 258573384 11. moodle_exception->__construct() /Users/skodak/server/workspace/moodle25/lib/ddllib.php:81
            621.6803 258573528 12. core_string_manager->string_exists() /Users/skodak/server/workspace/moodle25/lib/setuplib.php:138
            621.6803 258573744 13. core_string_manager->load_component_strings() /Users/skodak/server/workspace/moodle25/lib/moodlelib.php:6836

            PHP Fatal error: Uncaught exception 'ddl_table_missing_exception' with message 'error/ddltablenotexist
            $a contents: backup_ids_temp' in /Users/skodak/server/workspace/moodle25/lib/ddl/database_manager.php:324
            Stack trace:
            #0 /Users/skodak/server/workspace/moodle25/lib/dml/moodle_temptables.php(131): database_manager->drop_table(Object(xmldb_table))
            #1 /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php(352): moodle_temptables->dispose()
            #2 /Users/skodak/server/workspace/moodle25/lib/dml/pgsql_native_moodle_database.php(217): moodle_database->dispose()
            #3 /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php(146): pgsql_native_moodle_database->dispose()
            #4 [internal function]: moodle_database->__destruct()
            #5

            {main}
            thrown in /Users/skodak/server/workspace/moodle25/lib/ddl/database_manager.php on line 324
            PHP Stack trace:
            PHP 1. {main}

            () /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:0
            PHP 2. PHPUnit_TextUI_Command::main() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:63
            PHP 3. PHPUnit_TextUI_Command->run() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129

            Fatal error: Uncaught exception 'ddl_table_missing_exception' with message ' in /Users/skodak/server/workspace/moodle25/lib/ddl/database_manager.php on line 324

            Call Stack:
            0.0002 227696 1.

            {main}() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:0
            0.0188 538400 2. PHPUnit_TextUI_Command::main() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:63
            0.0188 539024 3. PHPUnit_TextUI_Command->run() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129

            ddl_table_missing_exception: error/ddltablenotexist
            $a contents: backup_ids_temp in /Users/skodak/server/workspace/moodle25/lib/ddl/database_manager.php on line 324

            Call Stack:
            0.0002 227696 1. {main}

            () /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:0
            0.0188 538400 2. PHPUnit_TextUI_Command::main() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:63
            0.0188 539024 3. PHPUnit_TextUI_Command->run() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129
            621.6757 258499376 4. moodle_database->__destruct() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:0
            621.6757 258499376 5. pgsql_native_moodle_database->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:146
            621.6757 258499376 6. moodle_database->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/pgsql_native_moodle_database.php:217
            621.6757 258499648 7. moodle_temptables->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:352
            621.6758 258500976 8. database_manager->drop_table() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_temptables.php:131

            Show
            Petr Skoda added a comment - There were 3 errors: 1) moodlesimplepie_testcase::test_getfeed Undefined property: count /Users/skodak/server/workspace/moodle25/lib/filelib.php:3029 /Users/skodak/server/workspace/moodle25/lib/filelib.php:3214 /Users/skodak/server/workspace/moodle25/lib/filelib.php:3303 /Users/skodak/server/workspace/moodle25/lib/simplepie/moodle_simplepie.php:142 /Users/skodak/server/workspace/moodle25/lib/simplepie/simplepie.class.php:1594 /Users/skodak/server/workspace/moodle25/lib/simplepie/moodle_simplepie.php:79 /Users/skodak/server/workspace/moodle25/lib/tests/rsslib_test.php:52 /Users/skodak/server/workspace/moodle25/lib/phpunit/classes/basic_testcase.php:64 To re-run: vendor/bin/phpunit --colors moodlesimplepie_testcase lib/tests/rsslib_test.php 2) moodlesimplepie_testcase::test_redirect Undefined property: count /Users/skodak/server/workspace/moodle25/lib/filelib.php:3029 /Users/skodak/server/workspace/moodle25/lib/filelib.php:3214 /Users/skodak/server/workspace/moodle25/lib/filelib.php:3303 /Users/skodak/server/workspace/moodle25/lib/simplepie/moodle_simplepie.php:142 /Users/skodak/server/workspace/moodle25/lib/simplepie/simplepie.class.php:1594 /Users/skodak/server/workspace/moodle25/lib/simplepie/moodle_simplepie.php:79 /Users/skodak/server/workspace/moodle25/lib/tests/rsslib_test.php:138 /Users/skodak/server/workspace/moodle25/lib/phpunit/classes/basic_testcase.php:64 To re-run: vendor/bin/phpunit --colors moodlesimplepie_testcase lib/tests/rsslib_test.php 3) core_course_external_testcase::test_duplicate_course coding_exception: Coding error detected, it must be fixed by a programmer: backup_helper::store_backup_file() expects valid $filepath parameter /Users/skodak/server/workspace/moodle25/backup/util/helper/backup_helper.class.php:218 /Users/skodak/server/workspace/moodle25/backup/moodle2/backup_stepslib.php:1638 /Users/skodak/server/workspace/moodle25/backup/util/plan/backup_execution_step.class.php:34 /Users/skodak/server/workspace/moodle25/backup/util/plan/base_task.class.php:153 /Users/skodak/server/workspace/moodle25/backup/util/plan/base_plan.class.php:163 /Users/skodak/server/workspace/moodle25/backup/util/plan/backup_plan.class.php:110 /Users/skodak/server/workspace/moodle25/backup/controller/backup_controller.class.php:309 /Users/skodak/server/workspace/moodle25/course/externallib.php:1042 /Users/skodak/server/workspace/moodle25/course/tests/externallib_test.php:636 /Users/skodak/server/workspace/moodle25/lib/phpunit/classes/advanced_testcase.php:76 To re-run: vendor/bin/phpunit --colors core_course_external_testcase course/tests/externallib_test.php – There was 1 failure: 1) zip_packer_testcase::test_archive_to_pathname Failed asserting that false is true. /Users/skodak/server/workspace/moodle25/lib/filestorage/tests/zip_packer_test.php:139 /Users/skodak/server/workspace/moodle25/lib/phpunit/classes/advanced_testcase.php:76 To re-run: vendor/bin/phpunit --colors zip_packer_testcase lib/filestorage/tests/zip_packer_test.php FAILURES! Tests: 1714, Assertions: 30465, Failures: 1, Errors: 3, Skipped: 11. Potential coding error - existing temptables found when disposing database. Must be dropped! PHP Notice: Trying to get property of non-object in /Users/skodak/server/workspace/moodle25/lib/moodlelib.php on line 6743 PHP Stack trace: PHP 1. {main}() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:0 PHP 2. PHPUnit_TextUI_Command::main() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:63 PHP 3. PHPUnit_TextUI_Command->run() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129 PHP 4. moodle_database->__destruct() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:0 PHP 5. pgsql_native_moodle_database->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:146 PHP 6. moodle_database->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/pgsql_native_moodle_database.php:217 PHP 7. moodle_temptables->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:352 PHP 8. database_manager->drop_table() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_temptables.php:131 PHP 9. ddl_table_missing_exception->__construct() /Users/skodak/server/workspace/moodle25/lib/ddl/database_manager.php:324 PHP 10. ddl_exception->__construct() /Users/skodak/server/workspace/moodle25/lib/ddllib.php:94 PHP 11. moodle_exception->__construct() /Users/skodak/server/workspace/moodle25/lib/ddllib.php:81 PHP 12. core_string_manager->string_exists() /Users/skodak/server/workspace/moodle25/lib/setuplib.php:138 PHP 13. core_string_manager->load_component_strings() /Users/skodak/server/workspace/moodle25/lib/moodlelib.php:6836 Notice: Trying to get property of non-object in /Users/skodak/server/workspace/moodle25/lib/moodlelib.php on line 6743 Call Stack: 0.0002 227696 1. {main} () /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:0 0.0188 538400 2. PHPUnit_TextUI_Command::main() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:63 0.0188 539024 3. PHPUnit_TextUI_Command->run() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129 621.6757 258499376 4. moodle_database->__destruct() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:0 621.6757 258499376 5. pgsql_native_moodle_database->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:146 621.6757 258499376 6. moodle_database->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/pgsql_native_moodle_database.php:217 621.6757 258499648 7. moodle_temptables->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:352 621.6758 258500976 8. database_manager->drop_table() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_temptables.php:131 621.6802 258573192 9. ddl_table_missing_exception->__construct() /Users/skodak/server/workspace/moodle25/lib/ddl/database_manager.php:324 621.6802 258573288 10. ddl_exception->__construct() /Users/skodak/server/workspace/moodle25/lib/ddllib.php:94 621.6803 258573384 11. moodle_exception->__construct() /Users/skodak/server/workspace/moodle25/lib/ddllib.php:81 621.6803 258573528 12. core_string_manager->string_exists() /Users/skodak/server/workspace/moodle25/lib/setuplib.php:138 621.6803 258573744 13. core_string_manager->load_component_strings() /Users/skodak/server/workspace/moodle25/lib/moodlelib.php:6836 PHP Fatal error: Uncaught exception 'ddl_table_missing_exception' with message 'error/ddltablenotexist $a contents: backup_ids_temp' in /Users/skodak/server/workspace/moodle25/lib/ddl/database_manager.php:324 Stack trace: #0 /Users/skodak/server/workspace/moodle25/lib/dml/moodle_temptables.php(131): database_manager->drop_table(Object(xmldb_table)) #1 /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php(352): moodle_temptables->dispose() #2 /Users/skodak/server/workspace/moodle25/lib/dml/pgsql_native_moodle_database.php(217): moodle_database->dispose() #3 /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php(146): pgsql_native_moodle_database->dispose() #4 [internal function] : moodle_database->__destruct() #5 {main} thrown in /Users/skodak/server/workspace/moodle25/lib/ddl/database_manager.php on line 324 PHP Stack trace: PHP 1. {main} () /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:0 PHP 2. PHPUnit_TextUI_Command::main() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:63 PHP 3. PHPUnit_TextUI_Command->run() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129 Fatal error: Uncaught exception 'ddl_table_missing_exception' with message ' in /Users/skodak/server/workspace/moodle25/lib/ddl/database_manager.php on line 324 Call Stack: 0.0002 227696 1. {main}() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:0 0.0188 538400 2. PHPUnit_TextUI_Command::main() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:63 0.0188 539024 3. PHPUnit_TextUI_Command->run() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129 ddl_table_missing_exception: error/ddltablenotexist $a contents: backup_ids_temp in /Users/skodak/server/workspace/moodle25/lib/ddl/database_manager.php on line 324 Call Stack: 0.0002 227696 1. {main} () /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:0 0.0188 538400 2. PHPUnit_TextUI_Command::main() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/composer/bin/phpunit:63 0.0188 539024 3. PHPUnit_TextUI_Command->run() /Users/skodak/server/workspace/moodle25/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129 621.6757 258499376 4. moodle_database->__destruct() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:0 621.6757 258499376 5. pgsql_native_moodle_database->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:146 621.6757 258499376 6. moodle_database->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/pgsql_native_moodle_database.php:217 621.6757 258499648 7. moodle_temptables->dispose() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_database.php:352 621.6758 258500976 8. database_manager->drop_table() /Users/skodak/server/workspace/moodle25/lib/dml/moodle_temptables.php:131
            Hide
            Aparup Banerjee added a comment -

            thanks, i've integrated that into 24 and 25.

            ps: i see it in 23 and its not used there too. any reason not to fix?

            Show
            Aparup Banerjee added a comment - thanks, i've integrated that into 24 and 25. ps: i see it in 23 and its not used there too. any reason not to fix?
            Hide
            Petr Skoda added a comment -

            Feel free to cherry pick, but I did not test if there are other problems. By the time PHP 5.5 gets released we will not support Moodle 2.3.

            Show
            Petr Skoda added a comment - Feel free to cherry pick, but I did not test if there are other problems. By the time PHP 5.5 gets released we will not support Moodle 2.3.
            Hide
            David Monllaó added a comment -

            Still with this, tomorrow will be done, sorry for the delay

            Show
            David Monllaó added a comment - Still with this, tomorrow will be done, sorry for the delay
            Hide
            David Monllaó added a comment -

            Hi,

            Using PHP 5.5.0.3, I ran a moodle installation and all as expected but running phpunit (composer install) I got the following output, not sure if it is a real failure as is related with collation and maybe I missed something when setting up the db instance, waiting for feedback from the phpunit experts to pass/fail.

            Moodle 2.5beta+ (Build: 20130411), pgsql, b3661ab272284da54e29428371b9503f66bc1a73
            PHPUnit 3.7.19 by Sebastian Bergmann.
             
            Configuration read from /var/www/INTEGRATION/master/phpunit.xml
             
            .............................................................   61 / 1769 (  3%)
            .............................................................  122 / 1769 (  6%)
            .............................................................  183 / 1769 ( 10%)
            .............................................................  244 / 1769 ( 13%)
            .............................................................  305 / 1769 ( 17%)
            .............................................................  366 / 1769 ( 20%)
            .............................................................  427 / 1769 ( 24%)
            .............................................................  488 / 1769 ( 27%)
            .............................................................  549 / 1769 ( 31%)
            .............................................................  610 / 1769 ( 34%)
            ...........................F.................................  671 / 1769 ( 37%)
            .............................................................  732 / 1769 ( 41%)
            .............................................................  793 / 1769 ( 44%)
            .............................................................  854 / 1769 ( 48%)
            .............................................................  915 / 1769 ( 51%)
            .............................................................  976 / 1769 ( 55%)
            ............................................................. 1037 / 1769 ( 58%)
            ............................................................. 1098 / 1769 ( 62%)
            ............................................................. 1159 / 1769 ( 65%)
            S..SSS........................S.............................. 1220 / 1769 ( 68%)
            ............................................................. 1281 / 1769 ( 72%)
            ............................................................. 1342 / 1769 ( 75%)
            ............................................................. 1403 / 1769 ( 79%)
            ............................................................. 1464 / 1769 ( 82%)
            ............................................................. 1525 / 1769 ( 86%)
            ............................................................. 1586 / 1769 ( 89%)
            ............................................................. 1647 / 1769 ( 93%)
            ............................................................. 1708 / 1769 ( 96%)
            ............................................................. 1769 / 1769 (100%)
             
             
            Time: 07:19, Memory: 228.50Mb
             
            There was 1 failure:
             
            1) collatorlib_testcase::test_asort
            Failed asserting that Array (
                0 => 'Aac'
                1 => 'aac'
                2 => 'cc'
            ) is identical to Array (
                0 => 'aac'
                1 => 'Aac'
                2 => 'cc'
            ).
             
            /var/www/INTEGRATION/master/lib/tests/textlib_test.php:446
            /var/www/INTEGRATION/master/lib/phpunit/classes/basic_testcase.php:64
             
            To re-run:
             vendor/bin/phpunit collatorlib_testcase lib/tests/textlib_test.php
             
            FAILURES!
            Tests: 1769, Assertions: 31077, Failures: 1, Skipped: 5.
            

            Show
            David Monllaó added a comment - Hi, Using PHP 5.5.0.3, I ran a moodle installation and all as expected but running phpunit (composer install) I got the following output, not sure if it is a real failure as is related with collation and maybe I missed something when setting up the db instance, waiting for feedback from the phpunit experts to pass/fail. Moodle 2.5beta+ (Build: 20130411), pgsql, b3661ab272284da54e29428371b9503f66bc1a73 PHPUnit 3.7.19 by Sebastian Bergmann. Configuration read from /var/www/INTEGRATION/master/phpunit.xml ............................................................. 61 / 1769 ( 3%) ............................................................. 122 / 1769 ( 6%) ............................................................. 183 / 1769 ( 10%) ............................................................. 244 / 1769 ( 13%) ............................................................. 305 / 1769 ( 17%) ............................................................. 366 / 1769 ( 20%) ............................................................. 427 / 1769 ( 24%) ............................................................. 488 / 1769 ( 27%) ............................................................. 549 / 1769 ( 31%) ............................................................. 610 / 1769 ( 34%) ...........................F................................. 671 / 1769 ( 37%) ............................................................. 732 / 1769 ( 41%) ............................................................. 793 / 1769 ( 44%) ............................................................. 854 / 1769 ( 48%) ............................................................. 915 / 1769 ( 51%) ............................................................. 976 / 1769 ( 55%) ............................................................. 1037 / 1769 ( 58%) ............................................................. 1098 / 1769 ( 62%) ............................................................. 1159 / 1769 ( 65%) S..SSS........................S.............................. 1220 / 1769 ( 68%) ............................................................. 1281 / 1769 ( 72%) ............................................................. 1342 / 1769 ( 75%) ............................................................. 1403 / 1769 ( 79%) ............................................................. 1464 / 1769 ( 82%) ............................................................. 1525 / 1769 ( 86%) ............................................................. 1586 / 1769 ( 89%) ............................................................. 1647 / 1769 ( 93%) ............................................................. 1708 / 1769 ( 96%) ............................................................. 1769 / 1769 (100%) Time: 07:19, Memory: 228.50Mb There was 1 failure: 1) collatorlib_testcase::test_asort Failed asserting that Array ( 0 => 'Aac' 1 => 'aac' 2 => 'cc' ) is identical to Array ( 0 => 'aac' 1 => 'Aac' 2 => 'cc' ). /var/www/INTEGRATION/master/lib/tests/textlib_test.php:446 /var/www/INTEGRATION/master/lib/phpunit/classes/basic_testcase.php:64 To re-run: vendor/bin/phpunit collatorlib_testcase lib/tests/textlib_test.php FAILURES! Tests: 1769, Assertions: 31077, Failures: 1, Skipped: 5.
            Hide
            David Monllaó added a comment -

            Passing as it was because of the missing intl extension

            Show
            David Monllaó added a comment - Passing as it was because of the missing intl extension
            Hide
            Aparup Banerjee added a comment -

            Thanks David

            Show
            Aparup Banerjee added a comment - Thanks David
            Hide
            Dan Poltawski added a comment -

            Blooming Marvelous! It's time for a knees up - your changes are upstream!

            Thanks for making Moodle better!

            Toodle pip

            Show
            Dan Poltawski added a comment - Blooming Marvelous! It's time for a knees up - your changes are upstream! Thanks for making Moodle better! Toodle pip

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: