Moodle
  1. Moodle
  2. MDL-38808

Remove deprecated unzip_file function from qformat blackboard_six plugin

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.6, 2.4.3
    • Fix Version/s: 2.5
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      Go to question bank import. Import the attached zip file testgen_images.ZIP using the "Blackboard" format and verify a multichoice question with images of books both in the question text and in answers is correctly imported.

      Show
      Go to question bank import. Import the attached zip file testgen_images.ZIP using the "Blackboard" format and verify a multichoice question with images of books both in the question text and in answers is correctly imported.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:

      Description

      While reviewing all tracker issues with the word "blackboard", I found that blackboard_six is using the deprecated unzip_file function.
      This is mentioned by Anthony borrow in MDL-24343.
      I am not able to fix the other occurrence mentioned in this issue because I am unfamiliar with the code in component lib, but I can at least fix the blackboard_six code that I know better.
      I will also fix my proposed code for MDL-30001 that was also using the same function.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Jean-Michel Vedrine added a comment -

            This will half-resolve MDL-24343

            Show
            Jean-Michel Vedrine added a comment - This will half-resolve MDL-24343
            Hide
            Jean-Michel Vedrine added a comment -

            adding sample file for testing.

            Show
            Jean-Michel Vedrine added a comment - adding sample file for testing.
            Hide
            Jean-Michel Vedrine added a comment -

            I don't know if i should backport this to stable branchs ?

            Show
            Jean-Michel Vedrine added a comment - I don't know if i should backport this to stable branchs ?
            Hide
            Jean-Michel Vedrine added a comment -

            Hello Tim,
            I think this is ready for peer review but as this is a bug fix it can wait after 2.5 code freeze if you have more urgent things to look at.

            Show
            Jean-Michel Vedrine added a comment - Hello Tim, I think this is ready for peer review but as this is a bug fix it can wait after 2.5 code freeze if you have more urgent things to look at.
            Hide
            Jean-Michel Vedrine added a comment -

            Grr, I just spotted that commit's comment is too long

            Show
            Jean-Michel Vedrine added a comment - Grr, I just spotted that commit's comment is too long
            Hide
            Tim Hunt added a comment -

            I don't think we should back-port this, since it is only a code cleanup.

            If you get time, you could amend the commit to shorten the comment before it is integrated, but I am submitting for integration, since the code change is fine.

            Show
            Tim Hunt added a comment - I don't think we should back-port this, since it is only a code cleanup. If you get time, you could amend the commit to shorten the comment before it is integrated, but I am submitting for integration, since the code change is fine.
            Hide
            Dan Poltawski added a comment -

            Integrated to master - thanks Jean-Michel

            Show
            Dan Poltawski added a comment - Integrated to master - thanks Jean-Michel
            Hide
            Ankit Agarwal added a comment -

            works as described passing.
            Thanks

            Show
            Ankit Agarwal added a comment - works as described passing. Thanks
            Hide
            Dan Poltawski added a comment -

            Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

            line 1289 of \lib\changes.php: call to debugging()
            line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
            line 202 of \lib\now.php: call to moodleform->_is_poor_form()
            line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            Show
            Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: