Moodle
  1. Moodle
  2. MDL-38809

Gross inefficiency in the quiz manual grading report

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.3.6, 2.4.3, 2.5
        • Fix Version/s: 2.3.7, 2.4.4
        • Component/s: Quiz
        • Labels:
        • Testing Instructions:
          Hide

          You need a quiz with some attempts by students.

          1. Go to Results -> Manual grading.

          2. If necessary, click the 'Also show automatically graded attempts' link.

          3. Click one of the links to grade something.

          4. Try entering a grade that is out-of-range, and ensure the verification rejects it.

          5. Now save some grades that are in range.

          6. Go to Results -> Grades, and verify that the grades were saved correctly.

          Show
          You need a quiz with some attempts by students. 1. Go to Results -> Manual grading. 2. If necessary, click the 'Also show automatically graded attempts' link. 3. Click one of the links to grade something. 4. Try entering a grade that is out-of-range, and ensure the verification rejects it. 5. Now save some grades that are in range. 6. Go to Results -> Grades, and verify that the grades were saved correctly.
        • Affected Branches:
          MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
        • Fixed Branches:
          MOODLE_23_STABLE, MOODLE_24_STABLE
        • Pull from Repository:
        • Pull 2.4 Branch:
        • Pull 2.4 Diff URL:
        • Pull Master Branch:
        • Pull Master Diff URL:
        • Rank:
          48874

          Description

          In process_submitted_data it does
          $quba = question_engine::load_questions_usage_by_activity($qubaid);
          but then does not use $quba!

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Tim Hunt added a comment -

            Submitting for integration.

            Show
            Tim Hunt added a comment - Submitting for integration.
            Hide
            Permalink
            Aparup Banerjee added a comment -

            thanks. integrated into master, 24 and 23.

            Show
            Aparup Banerjee added a comment - thanks. integrated into master, 24 and 23.
            Hide
            Permalink
            Ankit Agarwal added a comment -

            Works as described.
            Noticed that during incorrect input "out of x" part is printed in red as well, not sure if we want that.
            Anyways as far as functionality goes, it passes the test.
            Thanks

            Show
            Ankit Agarwal added a comment - Works as described. Noticed that during incorrect input "out of x" part is printed in red as well, not sure if we want that. Anyways as far as functionality goes, it passes the test. Thanks
            Hide
            Permalink
            Dan Poltawski added a comment -

            Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

            line 1289 of \lib\changes.php: call to debugging()
            line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
            line 202 of \lib\now.php: call to moodleform->_is_poor_form()
            line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            Show
            Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: