Details

      Description

      As described in MDLQA-1564, a teacher can indent items on the course page

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Sorry, this is conflicting badly, leading to a lot of functions duplicated. I've tried just cherry-picking b180f0794a082c90cd660e41735e5eb6c02fc29d and seems to work, but I prefer you to rebase this properly on top of current integration or something like that.

            Reopening... feel free to re-send it once fixed, TIA!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Sorry, this is conflicting badly, leading to a lot of functions duplicated. I've tried just cherry-picking b180f0794a082c90cd660e41735e5eb6c02fc29d and seems to work, but I prefer you to rebase this properly on top of current integration or something like that. Reopening... feel free to re-send it once fixed, TIA!
            Hide
            cibot CiBoT added a comment -

            Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

            Show
            cibot CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
            Hide
            dmonllao David Monllaó added a comment -

            Same case as MDL-38549, they are using steps definitions introduced in different issues, the issue is ready to cherry-pick as long as the blockers are integrated

            Show
            dmonllao David Monllaó added a comment - Same case as MDL-38549 , they are using steps definitions introduced in different issues, the issue is ready to cherry-pick as long as the blockers are integrated
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, by cherry-picking the commit + whitespace fix, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, by cherry-picking the commit + whitespace fix, thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            nobody tested this, CI will tell us.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - nobody tested this, CI will tell us.
            Hide
            poltawski Dan Poltawski added a comment -

            Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

            line 1289 of \lib\changes.php: call to debugging()
            line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
            line 202 of \lib\now.php: call to moodleform->_is_poor_form()
            line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            Show
            poltawski Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            FYI: related MDLQA-1564 has been moved from MDLQA-1 to MDLQA-5249 (bag of behat-converted tests). Thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - FYI: related MDLQA-1564 has been moved from MDLQA-1 to MDLQA-5249 (bag of behat-converted tests). Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13