Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Enrolments
    • Labels:
    • Testing Instructions:
      Hide

      Prerequisites: Paypal, self, manual and cohort enrolment methods enabled at system level

      1. Set debugging to developer level
      2. Open a course and go to Course administration -> Users -> Enrolment methods
      3. For each of the following methods: paypal, self, manual and cohort:
        1. Open the enrolment method form page (add or edit an existing one)
        2. You SHOULD NOT see any debugging message
      Show
      Prerequisites: Paypal, self, manual and cohort enrolment methods enabled at system level Set debugging to developer level Open a course and go to Course administration -> Users -> Enrolment methods For each of the following methods: paypal, self, manual and cohort: Open the enrolment method form page (add or edit an existing one) You SHOULD NOT see any debugging message
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38821_master
    • Rank:
      48888

      Description

      After MDL-34311 there are a few enrolment methods forms that needs additional setType calls.

      I haven't checked all the enrolment methods, attaching backtrace of the ones I've found.

      Did you remember to call setType() for 'name'? Defaulting to PARAM_RAW cleaning.
      line 1275 of /lib/formslib.php: call to debugging()
      line 919 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 147 of /enrol/self/edit.php: call to moodleform->display()
      
      Did you remember to call setType() for 'courseid'? Defaulting to PARAM_RAW cleaning.
      line 1275 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 72 of /enrol/manual/edit.php: call to moodleform->moodleform()
      
      
      Did you remember to call setType() for 'name'? Defaulting to PARAM_RAW cleaning.
      line 1275 of /lib/formslib.php: call to debugging()
      line 919 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 105 of /enrol/cohort/edit.php: call to moodleform->display()
      
      Did you remember to call setType() for 'name'? Defaulting to PARAM_RAW cleaning.
      line 1275 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 61 of /enrol/paypal/edit.php: call to moodleform->moodleform()
      Did you remember to call setType() for 'cost'? Defaulting to PARAM_RAW cleaning.
      line 1275 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 61 of /enrol/paypal/edit.php: call to moodleform->moodleform()
      Did you remember to call setType() for 'id'? Defaulting to PARAM_RAW cleaning.
      line 1275 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 61 of /enrol/paypal/edit.php: call to moodleform->moodleform()
      Did you remember to call setType() for 'courseid'? Defaulting to PARAM_RAW cleaning.
      line 1275 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 61 of /enrol/paypal/edit.php: call to moodleform->moodleform()
      

        Issue Links

          Activity

          Hide
          David Monllaó added a comment -

          Marking as blocker, adding myself as watcher to send MDL-38619 to integration once this one is integrated

          Show
          David Monllaó added a comment - Marking as blocker, adding myself as watcher to send MDL-38619 to integration once this one is integrated
          Hide
          David Monllaó added a comment -

          Adding pull branches on top of integration, sending straight to integration as is blocking other issues

          Show
          David Monllaó added a comment - Adding pull branches on top of integration, sending straight to integration as is blocking other issues
          Hide
          David Monllaó added a comment -

          In case this issue can be integrated the following reopened issues can also be integrated:

          Show
          David Monllaó added a comment - In case this issue can be integrated the following reopened issues can also be integrated: MDL-38619 MDL-38620 MDL-38622
          Hide
          Dan Poltawski added a comment -

          Hi David,

          It was all good apart from the paypal cost param. Since that was a float typed by the user the field should've been PARAM_RAW and then used unformat_float(). I fixed that and integrated it cos this is blocking you.

          Show
          Dan Poltawski added a comment - Hi David, It was all good apart from the paypal cost param. Since that was a float typed by the user the field should've been PARAM_RAW and then used unformat_float(). I fixed that and integrated it cos this is blocking you.
          Hide
          David Monllaó added a comment -

          Hi,

          I saw the comment about PARAM_FLOAT and I thought there would be no problem with PARAM_TEXT, thanks

          Show
          David Monllaó added a comment - Hi, I saw the comment about PARAM_FLOAT and I thought there would be no problem with PARAM_TEXT, thanks
          Hide
          Jason Fowler added a comment -

          All working David, thanks.

          Show
          Jason Fowler added a comment - All working David, thanks.
          Hide
          Dan Poltawski added a comment -

          Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

          line 1289 of \lib\changes.php: call to debugging()
          line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
          line 202 of \lib\now.php: call to moodleform->_is_poor_form()
          line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          Show
          Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: