Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34311 Improve debugging when using default cleaning
  3. MDL-38821

Fix missing calls to setType in enrolment methods

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Enrolments
    • Labels:
    • Testing Instructions:
      Hide

      Prerequisites: Paypal, self, manual and cohort enrolment methods enabled at system level

      1. Set debugging to developer level
      2. Open a course and go to Course administration -> Users -> Enrolment methods
      3. For each of the following methods: paypal, self, manual and cohort:
        1. Open the enrolment method form page (add or edit an existing one)
        2. You SHOULD NOT see any debugging message
      Show
      Prerequisites: Paypal, self, manual and cohort enrolment methods enabled at system level Set debugging to developer level Open a course and go to Course administration -> Users -> Enrolment methods For each of the following methods: paypal, self, manual and cohort: Open the enrolment method form page (add or edit an existing one) You SHOULD NOT see any debugging message
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38821_master

      Description

      After MDL-34311 there are a few enrolment methods forms that needs additional setType calls.

      I haven't checked all the enrolment methods, attaching backtrace of the ones I've found.

      Did you remember to call setType() for 'name'? Defaulting to PARAM_RAW cleaning.
      line 1275 of /lib/formslib.php: call to debugging()
      line 919 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 147 of /enrol/self/edit.php: call to moodleform->display()
      

      Did you remember to call setType() for 'courseid'? Defaulting to PARAM_RAW cleaning.
      line 1275 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 72 of /enrol/manual/edit.php: call to moodleform->moodleform()
      

       
      Did you remember to call setType() for 'name'? Defaulting to PARAM_RAW cleaning.
      line 1275 of /lib/formslib.php: call to debugging()
      line 919 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 105 of /enrol/cohort/edit.php: call to moodleform->display()
      

      Did you remember to call setType() for 'name'? Defaulting to PARAM_RAW cleaning.
      line 1275 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 61 of /enrol/paypal/edit.php: call to moodleform->moodleform()
      Did you remember to call setType() for 'cost'? Defaulting to PARAM_RAW cleaning.
      line 1275 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 61 of /enrol/paypal/edit.php: call to moodleform->moodleform()
      Did you remember to call setType() for 'id'? Defaulting to PARAM_RAW cleaning.
      line 1275 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 61 of /enrol/paypal/edit.php: call to moodleform->moodleform()
      Did you remember to call setType() for 'courseid'? Defaulting to PARAM_RAW cleaning.
      line 1275 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 61 of /enrol/paypal/edit.php: call to moodleform->moodleform()
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dmonllao David Monllaó
                Reporter:
                dmonllao David Monllaó
                Integrator:
                Dan Poltawski
                Tester:
                Jason Fowler
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13