Details

    • Testing Instructions:
      Hide

      1) Uninstall composer completely (or use a site/user/installation without it)

      2) Define $CFG->behat_prefix and $CFG->behat_dataroot to be valid.

      3) Run "php admin/tool/behat/cli/init.php" from the dirrrot directory.

      4) TEST: The first step performed by that script is to download composer and install it. You should see some curl progress output and then the process continues with "All settings correct for using Composer". It doesn't matter if there are other problems later. This only fixes the download/installation of composer itself.

      Note: Without the patch the scripts ends with "Could not open input file: composer.phar".

      That's all...ciao

      Show
      1) Uninstall composer completely (or use a site/user/installation without it) 2) Define $CFG->behat_prefix and $CFG->behat_dataroot to be valid. 3) Run "php admin/tool/behat/cli/init.php" from the dirrrot directory. 4) TEST: The first step performed by that script is to download composer and install it. You should see some curl progress output and then the process continues with "All settings correct for using Composer". It doesn't matter if there are other problems later. This only fixes the download/installation of composer itself. Note: Without the patch the scripts ends with "Could not open input file: composer.phar". That's all...ciao
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      48895

      Description

      While testing / trying MDL-38817 this was discovered.

      It's the first time I was going to install behat in my dev environment following the instructions @ http://docs.moodle.org/dev/Acceptance_testing#Installation , so I executed:

      php admin/tool/behat/cli/init.php
      

      At the curl operation ended with a 404 error and the installation process of composer ended with error.

      Looking at the Docs, it seems that the URL we are fetching is incorrect, it should be:

       http://getcomposer.org/installer
      

      instead of:

      curl http://getcomposer.org/install
      

      So this is, simply, about to change that and verify that the behat install, does the composer installation properly.

      Ciao

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          Sent straight to integration (trivial) but set David as reviewer in case he wants to add his thumbs up (or down).

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Sent straight to integration (trivial) but set David as reviewer in case he wants to add his thumbs up (or down). Ciao
          Hide
          David Monllaó added a comment -

          My mistake, big +1

          Show
          David Monllaó added a comment - My mistake, big +1
          Hide
          Dan Poltawski added a comment -

          Integrated to master, thanks Eloy

          Show
          Dan Poltawski added a comment - Integrated to master, thanks Eloy
          Hide
          Dan Poltawski added a comment -

          Tested during integration, thanks!

          Show
          Dan Poltawski added a comment - Tested during integration, thanks!
          Hide
          Dan Poltawski added a comment -

          Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

          line 1289 of \lib\changes.php: call to debugging()
          line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
          line 202 of \lib\now.php: call to moodleform->_is_poor_form()
          line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          Show
          Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: