Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34311 Improve debugging when using default cleaning
  3. MDL-38833

Error when modifying student grade

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Forms Library, Gradebook
    • Labels:
    • Testing Instructions:
      Hide

      You'll need two gradeable activities. One using a numeric grade. The other using a custom scale.

      As a teacher or admin go to the grader report and turn editing on. Click the edit/cog icon next to an individual student grade. Tick 'overridden' if it isnt ticked already. Edit the student's grade and click update.

      Repeat this for both activities. Make sure you don't see the warning in this MDL's description and that the grade changes are saved correctly.

      Show
      You'll need two gradeable activities. One using a numeric grade. The other using a custom scale. As a teacher or admin go to the grader report and turn editing on. Click the edit/cog icon next to an individual student grade. Tick 'overridden' if it isnt ticked already. Edit the student's grade and click update. Repeat this for both activities. Make sure you don't see the warning in this MDL's description and that the grade changes are saved correctly.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38833_settype
    • Pull Master Diff URL:

      Description

      If I go to the grader report, turn editing on, click the edit icon for an individual student grade then save the resulting form the following is displayed.

      Did you remember to call setType() for 'finalgrade'? Defaulting to PARAM_RAW cleaning.
      		 
       
      		 
          line 1275 of /lib/formslib.php: call to debugging()
      		 
          line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      		 
          line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      		 
          line 105 of /grade/edit/tree/grade.php: call to moodleform->moodleform()

        Attachments

          Issue Links

          Discovered while testing

          Improvement - An enhancement to an existing Moodle feature. MDL-39360 Should we be using PARAM_RAW or PARAM_FLOAT for grades

          • Minor - Minor loss of function where workaround is possible
          • Open
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-38445 In Grades, a hidden test may reappear after an attempt by a student

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              • Assignee:
                andyjdavis Andrew Davis
                Reporter:
                andyjdavis Andrew Davis
                Peer reviewer:
                Ankit Agarwal
                Integrator:
                Damyon Wiese
                Tester:
                Damyon Wiese
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta, Jake Dallimore, Jun Pataleta
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13