Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38837

Check for http or https for include in openbadges backpack support.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5.2
    • Component/s: Badges
    • Testing Instructions:
      Hide

      This should be properly tested as I did not have required set up to do this myself. Testing requires web site to be accessible from the internet.

      When issuer.js from Mozilla Backpack is included, it should be now included through http or https, depending on your install. This can be checked through page source in the browser.

      If Mozilla backpack service is down, it should return a message advising user to try again later. This can be simulated by:

      1. Visiting the my badges page
      2. Opening the developer console and entering "OpenBadges = undefined;" without the quotes
      3. Clicking the "Download to backpack" icon

      For other testing:

      1. Make sure that you have backpack connection set up beforehand.
      2. Export of badges directly to the backpack can be done from two locations (mybadges.php page and issued badge page - badge.php). Try clicking "Add to backpack" from any of those two locations.
      3. If there are no problems with the Mozilla Backpack and user web site is accessible from the Internet, badge should be successfully added to the backpack.
      Show
      This should be properly tested as I did not have required set up to do this myself. Testing requires web site to be accessible from the internet. When issuer.js from Mozilla Backpack is included, it should be now included through http or https, depending on your install. This can be checked through page source in the browser. If Mozilla backpack service is down, it should return a message advising user to try again later. This can be simulated by: Visiting the my badges page Opening the developer console and entering "OpenBadges = undefined;" without the quotes Clicking the "Download to backpack" icon For other testing: Make sure that you have backpack connection set up beforehand. Export of badges directly to the backpack can be done from two locations (mybadges.php page and issued badge page - badge.php). Try clicking "Add to backpack" from any of those two locations. If there are no problems with the Mozilla Backpack and user web site is accessible from the Internet, badge should be successfully added to the backpack.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-38837_dev

      Description

      badges/badge.php

      contains js include for http://backpack.openbadges.org/issuer.js.

      This should be checking for http(s) and including the appropriate js to prevent mixed secure/insecure warnings.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  2 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Sep/13