Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38849

Field length for activating editor

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Quiz
    • Labels:
      None
    • Testing Instructions:
      Hide

      1. You need a form with collapsible editors (e.g. Create multiple choice question.)

      2. Try various languages, e.g. Hungarian and Chinese, and ensure that the 'Show/hide editing tools' text fits nicely in the UI tab.

      Show
      1. You need a form with collapsible editors (e.g. Create multiple choice question.) 2. Try various languages, e.g. Hungarian and Chinese, and ensure that the 'Show/hide editing tools' text fits nicely in the UI tab.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      The length of the field for the title to activate the editor should be flexible. As you can see in the German version its to short. See screenshot.

      I've seen this option now only in quiz module. Not quite sure if it is a general feature

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            Yes, we need to do something here.

            The problem is, making the tab much too wide looks ugly to me.

            And using width: auto means that the tab changes size when you toggle from show to hide, and that is also ugly.

            Perhaps wider tab is the least bad option.

            I will sleep on it and decided tomorrow.

            Show
            timhunt Tim Hunt added a comment - Yes, we need to do something here. The problem is, making the tab much too wide looks ugly to me. And using width: auto means that the tab changes size when you toggle from show to hide, and that is also ugly. Perhaps wider tab is the least bad option. I will sleep on it and decided tomorrow.
            Hide
            ralfh Ralf Hilgenstock added a comment -

            Hi Tim, forthe German language pack I've shortened the entries now, but we should look on other languages.

            Show
            ralfh Ralf Hilgenstock added a comment - Hi Tim, forthe German language pack I've shortened the entries now, but we should look on other languages.
            Hide
            jmvedrine Jean-Michel Vedrine added a comment -

            The same issue exists in french

            Show
            jmvedrine Jean-Michel Vedrine added a comment - The same issue exists in french
            Hide
            timhunt Tim Hunt added a comment -

            Looking at http://lang.moodle.org/local/amos/view.php?t=1365244322&v=2500&l=%2A&c=form&s=&d=editortoolbar&r=1&p=1, it seems that so far the prize for the longest string goes to Hungarian (Szerkesztőeszközök megjelenítése) and that is about twice as long as the English string.

            I think the only option is to make the tab as wide as the string. That has the unfortunate effect that the tab re-sizes slightly when you change from show to hide, but I can't see a way round that.

            Show
            timhunt Tim Hunt added a comment - Looking at http://lang.moodle.org/local/amos/view.php?t=1365244322&v=2500&l=%2A&c=form&s=&d=editortoolbar&r=1&p=1 , it seems that so far the prize for the longest string goes to Hungarian (Szerkesztőeszközök megjelenítése) and that is about twice as long as the English string. I think the only option is to make the tab as wide as the string. That has the unfortunate effect that the tab re-sizes slightly when you change from show to hide, but I can't see a way round that.
            Hide
            jmvedrine Jean-Michel Vedrine added a comment -

            And what about a beautiful icon replacing the text ?

            Show
            jmvedrine Jean-Michel Vedrine added a comment - And what about a beautiful icon replacing the text ?
            Hide
            timhunt Tim Hunt added a comment -

            OK, here is a fix.

            Show
            timhunt Tim Hunt added a comment - OK, here is a fix.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Tested by hacking the "en" string to a very loooong alternative and with the new CSS the width of the tab gets adapted to the text perfectly. So passing.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Tested by hacking the "en" string to a very loooong alternative and with the new CSS the width of the tab gets adapted to the text perfectly. So passing.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Your awesome contributions are now part of Moodle, your fav LMS out there.

            Closing this as fixed.

            Many thanks for all the hard work, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Your awesome contributions are now part of Moodle, your fav LMS out there. Closing this as fixed. Many thanks for all the hard work, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13