Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      With debug developer enabled and showing errors or alternatively looking to logs):

      Prepare some users.csv file, these contents can be ok (extracted from a behat test):

      username,password,firstname,lastname,email,cohort1
      tomjones,Pass1234*,Tom,Jones,tomjones@example.com,ASD
      marysmith,Pass1234*,Mary,Smith,marysmith@example.com,DSA
      bobjones,Pass1234*,Bob,Jones,bobjones@example.com,ASD
      alicesmith,Pass1234*,Alice,Smith,alicesmith@example.com,DSA
      

      go to admin->users->accounts->upload users

      upload the csv file, load users, preview and end the process (until the users have been created message.

      GOAL: not "setType()" debugging message is shown at all.

      That is, ciao

      Show
      With debug developer enabled and showing errors or alternatively looking to logs): Prepare some users.csv file, these contents can be ok (extracted from a behat test): username,password,firstname,lastname,email,cohort1 tomjones,Pass1234*,Tom,Jones,tomjones@example.com,ASD marysmith,Pass1234*,Mary,Smith,marysmith@example.com,DSA bobjones,Pass1234*,Bob,Jones,bobjones@example.com,ASD alicesmith,Pass1234*,Alice,Smith,alicesmith@example.com,DSA go to admin->users->accounts->upload users upload the csv file, load users, preview and end the process (until the users have been created message. GOAL: not "setType()" debugging message is shown at all. That is, ciao
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      48952

      Description

      MDL-34311 revealed some undefined types when uploading users. Fixing them (coz there are some behat tests showing them).

        Activity

        Hide
        Eloy Lafuente (stronk7) added a comment -

        Sending straight to integration, trivial enough.

        Show
        Eloy Lafuente (stronk7) added a comment - Sending straight to integration, trivial enough.
        Hide
        Dan Poltawski added a comment -

        Integrated, thanks Eloy

        Show
        Dan Poltawski added a comment - Integrated, thanks Eloy
        Hide
        Dan Poltawski added a comment -

        Passing thanks!

        Show
        Dan Poltawski added a comment - Passing thanks!
        Hide
        Dan Poltawski added a comment -

        Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

        line 1289 of \lib\changes.php: call to debugging()
        line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
        line 202 of \lib\now.php: call to moodleform->_is_poor_form()
        line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

        Show
        Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: