Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Calendar
    • Labels:
      None

      Description

      Missing setType call when managing calendar subscriptions

      Did you remember to call setType() for 'course'? Defaulting to PARAM_RAW cleaning.
      line 1291 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 59 of /calendar/managesubscriptions.php: call to moodleform->moodleform()
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              poltawski Dan Poltawski added a comment -

              I've fixed it and also removed a duplciate sesskey definition (its done by formslib internally)

              Show
              poltawski Dan Poltawski added a comment - I've fixed it and also removed a duplciate sesskey definition (its done by formslib internally)
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              integrated and tested, thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - integrated and tested, thanks!
              Hide
              poltawski Dan Poltawski added a comment -

              Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

              line 1289 of \lib\changes.php: call to debugging()
              line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
              line 202 of \lib\now.php: call to moodleform->_is_poor_form()
              line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

              Show
              poltawski Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13