Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Hub
    • Labels:

      Description

      Add community finder block > do a search on Mooch

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            markn Mark Nelson added a comment -

            Hi Jerome, patch looks perfect. Thanks.

            Show
            markn Mark Nelson added a comment - Hi Jerome, patch looks perfect. Thanks.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment - - edited

            Sorry, guys, once again... don't abuse the PARAM_TEXT one... it must be used only for titles and having in mind the support of the multi-language tags.

            As far as "search" is not a title nor should support multi-lang... I'd go for PARAM_NOTAGS surely.

            So... reopening... send it straight to integration when ready, TIA!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - - edited Sorry, guys, once again... don't abuse the PARAM_TEXT one... it must be used only for titles and having in mind the support of the multi-language tags. As far as "search" is not a title nor should support multi-lang... I'd go for PARAM_NOTAGS surely. So... reopening... send it straight to integration when ready, TIA!
            Hide
            cibot CiBoT added a comment -

            Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

            Show
            cibot CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
            Hide
            jerome Jérôme Mouneyrac added a comment -

            I was ok to use PARAM_TEXT because it's matching hub ws description and the issue didn't deserve too much time spent on the hub plugin. But PARAM_NOTAGS is not going to cause a big deal (just "weird" searches will not be possible) so I'll make the change.

            Show
            jerome Jérôme Mouneyrac added a comment - I was ok to use PARAM_TEXT because it's matching hub ws description and the issue didn't deserve too much time spent on the hub plugin. But PARAM_NOTAGS is not going to cause a big deal (just "weird" searches will not be possible) so I'll make the change.
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated, tested and pased.

            Show
            poltawski Dan Poltawski added a comment - Integrated, tested and pased.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks! You're changes are now spread to the world through this git and our source control repositories.

            No time to rest though, we've got days to make 2.5 the best yet!

            ciao

            Show
            poltawski Dan Poltawski added a comment - Thanks! You're changes are now spread to the world through this git and our source control repositories. No time to rest though, we've got days to make 2.5 the best yet! ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13