Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Select Bootstrap theme from Theme selector
      2. Add block Calendar if not already added.
      3. Click on the block calendar month which takes you to the calendar main page.
      4. Float the browser screen so that you can resize the window by pushing the right-hand side towards the left.
      5. TEST, when resizing the window, that the main calendar table does not extend beyond the centre column into the side blocks on the right.
      6. TEST again using the Simple theme.
      Show
      Select Bootstrap theme from Theme selector Add block Calendar if not already added. Click on the block calendar month which takes you to the calendar main page. Float the browser screen so that you can resize the window by pushing the right-hand side towards the left. TEST, when resizing the window, that the main calendar table does not extend beyond the centre column into the side blocks on the right. TEST again using the Simple theme.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-38896_master
    • Rank:
      48992

      Description

      When the screen is around 1024 pixels wide, the main calendar onon calendar/view.php?view=month&cal_d=1&cal_m=4&cal_y=2013&course=1 overflows on to the right blocks

        Activity

        Hide
        David Scotson added a comment -

        I'm not seeing this until I get down to about 900px, but I think it might depend on the language used and how long their weekday names are.

        If I change the names to Su M T W Th F Sa then it shrinks down as expected (though I'm testing with an empty calender so that content might affect it as well).

        I think if it only happens at 900px and below then it's not a particularly big problem. If it's happening at 1024 pixels then something should probably be done about it, possibly inserting soft-breaks into or truncating the day name in some way.

        Show
        David Scotson added a comment - I'm not seeing this until I get down to about 900px, but I think it might depend on the language used and how long their weekday names are. If I change the names to Su M T W Th F Sa then it shrinks down as expected (though I'm testing with an empty calender so that content might affect it as well). I think if it only happens at 900px and below then it's not a particularly big problem. If it's happening at 1024 pixels then something should probably be done about it, possibly inserting soft-breaks into or truncating the day name in some way.
        Hide
        Sam Hemelryk added a comment -

        Hi Mary,

        This gets a -1 from me presently sorry.

        Overriding another renderer method in the bootstrap theme. One of the tasks for after release is going to be removing the overridden renderers in the bootstrap theme and make fixes within core.
        In this particular case the renderer method is huge (not your fault at all) and the change being made is tiny.

        Having looked at the issue, and then at what others do I think we should just make these string changes in calendar/renderers.php anyway.

        I'll reopen this at the moment so that we can decide what to do.

        Many thanks
        Sam

        Show
        Sam Hemelryk added a comment - Hi Mary, This gets a -1 from me presently sorry. Overriding another renderer method in the bootstrap theme. One of the tasks for after release is going to be removing the overridden renderers in the bootstrap theme and make fixes within core. In this particular case the renderer method is huge (not your fault at all) and the change being made is tiny. Having looked at the issue, and then at what others do I think we should just make these string changes in calendar/renderers.php anyway. I'll reopen this at the moment so that we can decide what to do. Many thanks Sam
        Hide
        Mary Evans added a comment -

        I was thinking much the same thing after I commited this. Would be better all round if the strings where changed in CORE. Thanks for looking at this anyway.

        Show
        Mary Evans added a comment - I was thinking much the same thing after I commited this. Would be better all round if the strings where changed in CORE. Thanks for looking at this anyway.
        Hide
        CiBoT added a comment -

        Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

        Show
        CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
        Hide
        Sam Hemelryk added a comment -

        Cool thanks Mary.

        Would you like me to make the changes or are you happy to?

        Many thanks
        Sam

        Show
        Sam Hemelryk added a comment - Cool thanks Mary. Would you like me to make the changes or are you happy to? Many thanks Sam
        Hide
        Mary Evans added a comment -

        It's OK I can do this. Thanks

        Show
        Mary Evans added a comment - It's OK I can do this. Thanks
        Hide
        Mary Evans added a comment -

        All fixed n ready to roll!

        Show
        Mary Evans added a comment - All fixed n ready to roll!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        I'm not sure if this is going to fix anything really. If the main-calendar has events with medium strings (I just tried with "eat babanas @ superstore" in 2-3 days), then those events cause exactly the same problem to happen.

        So, abbreviating the day names always (that I was reticent about, no matter of the previous paragraph) doesn't sound to me like the best solution here.

        Hence my -0.5...ciao

        Show
        Eloy Lafuente (stronk7) added a comment - I'm not sure if this is going to fix anything really. If the main-calendar has events with medium strings (I just tried with "eat babanas @ superstore" in 2-3 days), then those events cause exactly the same problem to happen. So, abbreviating the day names always (that I was reticent about, no matter of the previous paragraph) doesn't sound to me like the best solution here. Hence my -0.5...ciao
        Hide
        Mary Evans added a comment - - edited

        But that's tables for you. It would probably be better changing the layout for the calendar to a grid so it could reshape if needed.

        Show
        Mary Evans added a comment - - edited But that's tables for you. It would probably be better changing the layout for the calendar to a grid so it could reshape if needed.
        Hide
        David Scotson added a comment -

        You can replicate the current behaviour by stopping the container from shrinking, so something like

        @media (min-width: 768px) {

        #page-calender-view .container fluid

        {min-width: 1024px;}

        }

        It needs to be in a media tag to stop it interfering with display on mobile devices which do want to be smaller than that.

        Now when you narrow the page the 3 columns wont shrink past that limit and the right column will start to disappear.

        Show
        David Scotson added a comment - You can replicate the current behaviour by stopping the container from shrinking, so something like @media (min-width: 768px) { #page-calender-view .container fluid {min-width: 1024px;} } It needs to be in a media tag to stop it interfering with display on mobile devices which do want to be smaller than that. Now when you narrow the page the 3 columns wont shrink past that limit and the right column will start to disappear.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Mary Evans added a comment - - edited

        Just redone this and added @media css rule.

        What I did not do is compile moodle.less => style/generated.css as not sure what the policy is going to be, nor if Eloys proposed changes have been applied or are going to be applied?

        Show
        Mary Evans added a comment - - edited Just redone this and added @media css rule. What I did not do is compile moodle.less => style/generated.css as not sure what the policy is going to be, nor if Eloys proposed changes have been applied or are going to be applied?
        Hide
        Sam Hemelryk added a comment -

        Alrighty, this has been integrated now

        Show
        Sam Hemelryk added a comment - Alrighty, this has been integrated now
        Hide
        Mary Evans added a comment -

        Show
        Mary Evans added a comment -
        Hide
        Ankit Agarwal added a comment -

        Works as described.
        Thanks

        Show
        Ankit Agarwal added a comment - Works as described. Thanks
        Hide
        Dan Poltawski added a comment -

        Thanks! You're changes are now spread to the world through this git and our source control repositories.

        No time to rest though, we've got days to make 2.5 the best yet!

        ciao

        Show
        Dan Poltawski added a comment - Thanks! You're changes are now spread to the world through this git and our source control repositories. No time to rest though, we've got days to make 2.5 the best yet! ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: