Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38856 META: Issues around Bootstrapbase and Clean theme
  3. MDL-38900

Bootstrap theme - Topics section highlighting seems more a section hidden or disabled

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Enter a course with the weekly format, locate the current week.

      Enter a topic based course. Find/select the highlighted week.

      Both should be pale blue/green rather than gray, and should look "highlighted" rather than "hidden/disabled"

      Show
      Enter a course with the weekly format, locate the current week. Enter a topic based course. Find/select the highlighted week. Both should be pale blue/green rather than gray, and should look "highlighted" rather than "hidden/disabled"
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-38900-master

      Description

      Is only my point of view, so feel free to ignore the issue, IMO a grey color for a hightlighted section is not the most appropriate color.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            bawjaws David Scotson added a comment -

            I switched this from gray to the standard @infoBackground color (pale blue) used in Bootstrap to say this is important so we've made it stand out, but not in a worrying way (which would be amber or red).

            https://github.com/bmbrands/theme_bootstrap/commit/ffe8c012588464a069f8e744dbc7f0ed08d8d39a

            Show
            bawjaws David Scotson added a comment - I switched this from gray to the standard @infoBackground color (pale blue) used in Bootstrap to say this is important so we've made it stand out, but not in a worrying way (which would be amber or red). https://github.com/bmbrands/theme_bootstrap/commit/ffe8c012588464a069f8e744dbc7f0ed08d8d39a
            Hide
            bawjaws David Scotson added a comment -

            Changed the color variable to something brighter. Also moved the style into the course file as that's where it belongs.

            Show
            bawjaws David Scotson added a comment - Changed the color variable to something brighter. Also moved the style into the course file as that's where it belongs.
            Hide
            lazydaisy Mary Evans added a comment -

            Looks good and works as expected in both Bootstrap and Simple themes.

            Show
            lazydaisy Mary Evans added a comment - Looks good and works as expected in both Bootstrap and Simple themes.
            Hide
            lazydaisy Mary Evans added a comment -

            Submitting for Integration Review.

            Show
            lazydaisy Mary Evans added a comment - Submitting for Integration Review.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks guys, this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks guys, this has been integrated now.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Tested during review and passed.

            Show
            samhemelryk Sam Hemelryk added a comment - Tested during review and passed.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            I feel myself really alone tonight! So was time to push your fixes upstream!

            "Lest we forget. We will remember them."

            Thanks and ciao!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - I feel myself really alone tonight! So was time to push your fixes upstream! "Lest we forget. We will remember them." Thanks and ciao!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13