Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38923

Cannot dock blocks with Bootstrapbase/clean theme

    Details

    • Testing Instructions:
      Hide

      Test one

      1. Log in.
      2. Change to clean theme.
      3. Dock a block and check the dock works Ok.
      4. Remember which blocks you'd docked, refresh the page and check they're still docked.
      5. Dock all of the blocks on the left and check that the left area gets compacted (content area gets the space).
      6. Undock a block from the left and check that the left area is displayed correctly again.
      7. Dock all blocks on the right.
      8. Check that the right area gets compacted.
      9. Undock a block on the right and check that the right area returns to normal.
      10. Dock all blocks.
      11. Check that the content gets the full width of the page.
      12. Refresh the page.
      13. Check that all blocks are still docked.
      14. Undock everything using the "Undock all" button on the dock

      Test two.

      1. Log in as an admin.
      2. Create a new course with one topic and clean as its theme.
      3. Create three page activities, give them the following content: <p style='width:100%;background-color:#FFA800;">Blah</p>
      4. In the first make sure you've blocks on both the left and right.
      5. In the second move all blocks on the right over to the left.
      6. In the third move all blocks on the left over to the right.
      7. Turn off editing
      8. Browse each activity and complete the following checking that the layout doesn't visually jump and is correct. (of course if there are no blocks in the region below just skip that step).
        1. Undock all blocks. Refresh.
        2. Dock the blocks on the left. Refresh.
        3. Dock the blocks on the right. Refresh.
        4. Undock all blocks. Refresh.
        5. Dock all blocks. Refresh.
      9. Change to Hebrew and repeat.
      10. Disable JavaScript and repeat.
      11. Change back to English and repeat.

      You should have tested the the pages in both English and Hebrew both with JS enabled and JS disabled.

      Make a quick test in standard/other themes to make sure the docking works there as it did before

      Show
      Test one Log in. Change to clean theme. Dock a block and check the dock works Ok. Remember which blocks you'd docked, refresh the page and check they're still docked. Dock all of the blocks on the left and check that the left area gets compacted (content area gets the space). Undock a block from the left and check that the left area is displayed correctly again. Dock all blocks on the right. Check that the right area gets compacted. Undock a block on the right and check that the right area returns to normal. Dock all blocks. Check that the content gets the full width of the page. Refresh the page. Check that all blocks are still docked. Undock everything using the "Undock all" button on the dock Test two. Log in as an admin. Create a new course with one topic and clean as its theme. Create three page activities, give them the following content: <p style='width:100%;background-color:#FFA800;">Blah</p> In the first make sure you've blocks on both the left and right. In the second move all blocks on the right over to the left. In the third move all blocks on the left over to the right. Turn off editing Browse each activity and complete the following checking that the layout doesn't visually jump and is correct. (of course if there are no blocks in the region below just skip that step). Undock all blocks. Refresh. Dock the blocks on the left. Refresh. Dock the blocks on the right. Refresh. Undock all blocks. Refresh. Dock all blocks. Refresh. Change to Hebrew and repeat. Disable JavaScript and repeat. Change back to English and repeat. You should have tested the the pages in both English and Hebrew both with JS enabled and JS disabled. Make a quick test in standard/other themes to make sure the docking works there as it did before
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      38923-27
    • Pull Master Diff URL:
    • Story Points (Obsolete):
      13
    • Sprint:
      FRONTEND Sprint 8

      Description

      I suspect this is intentional behaviour. It may have been discussed and there may be reasoning for this.

      I thought I would report this distinction here in case no one had noticed and it was not previously discussed.

        Gliffy Diagrams

          Attachments

          1. bootstrap_docking.png
            bootstrap_docking.png
            40 kB
          2. clean-dock-blocks.png
            clean-dock-blocks.png
            48 kB
          3. css_problems.png
            css_problems.png
            42 kB
          4. narrow_cropped.png
            narrow_cropped.png
            29 kB
          5. narrow_expanded.png
            narrow_expanded.png
            22 kB
          6. narrow_overlapping.png
            narrow_overlapping.png
            22 kB
          7. rtl_cropped.png
            rtl_cropped.png
            17 kB

            Issue Links

              Activity

                People

                • Votes:
                  44 Vote for this issue
                  Watchers:
                  52 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/May/14