Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38999

Europe/Tallinn current DST information is incorrect in http://download.moodle.org/timezone/

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.10, 2.2.9, 2.3.3, 2.4.3, 2.5
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      Need to initialize phpunit site to ensure that the fixed timezones are loaded to it:

      • sudo -u (wwwuser) php admin/tool/phpunit/cli/unit.php --drop
      • sudo -u (wwwuser) php admin/tool/phpunit/cli/init.php

      1) TEST: phpunit tests are passing (lib/tests/moodlelib_test.php specifically).

      2) Disable network access, verify you don't have any olson/timezones file in your dataroot/temp directory. The go to admin->location->update timezones and click on "continue". It's possible that you get some curl warning because of the disabled network access.

      3) TEST: must end with 2296 entries imported from dirroot/lib/timezone.txt (double check the source is that, any other is incorrect).

      4) Go to http://www.timeanddate.com/worldclock/city.html?n=242 and you will see the current hour in Tallinn.

      5) TEST: Go to your profile and set your TZ to Europe/Tallinn. Save changes. The last access time must match the time shown @ timeandate.com (with only seconds of difference).

      6) Optionally, repeat 4) and 5) for other timezones (some comments below you will find the problematic ones (pastebin).

      That is all, ciao

      Show
      Need to initialize phpunit site to ensure that the fixed timezones are loaded to it: sudo -u (wwwuser) php admin/tool/phpunit/cli/unit.php --drop sudo -u (wwwuser) php admin/tool/phpunit/cli/init.php 1) TEST: phpunit tests are passing (lib/tests/moodlelib_test.php specifically). 2) Disable network access, verify you don't have any olson/timezones file in your dataroot/temp directory. The go to admin->location->update timezones and click on "continue". It's possible that you get some curl warning because of the disabled network access. 3) TEST: must end with 2296 entries imported from dirroot/lib/timezone.txt (double check the source is that, any other is incorrect). 4) Go to http://www.timeanddate.com/worldclock/city.html?n=242 and you will see the current hour in Tallinn. 5) TEST: Go to your profile and set your TZ to Europe/Tallinn. Save changes. The last access time must match the time shown @ timeandate.com (with only seconds of difference). 6) Optionally, repeat 4) and 5) for other timezones (some comments below you will find the problematic ones (pastebin). That is all, ciao
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      The Moodle timezone information database (http://download.moodle.org/timezone/) has an error in it regarding the latest timezone information about Europe/Tallinn. The file currently reads:
      943,Europe/Tallinn,2002,EU,120,0,0,0,0,0,00:00,0,0,0,0,00:00

      Estonia belongs to the EU and has adopted the EU-wide DST (Daylight Saving Time) system since 2002. The http://www.iana.org/time-zones database has the correct information about Europe/Tallinn but for some reason this information is not presented correctly in the Moodle timezone database.

      The correct information should be:
      943,Europe/Tallinn,2002,EU,120,60,3,-1,0,0,1:00,10,-1,0,0,1:00

      Could someone double-check this and fix the Moodle timezone database if this error is confirmed?

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/May/13