Moodle
  1. Moodle
  2. MDL-39006

Move on to 5.3.3 in harcoded dependencies for Moodle 2.5

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Installation
    • Labels:
    • Testing Instructions:
      Hide

      Note to the testers, if switching to older version is not viable, alternatively you can always look for all the lines changed in the patch and replace the 5.3.3 there by your current PHP version + 1, to force the tests to fail.

      1) Try installing Moodle, both with the web and the cli installers with an older (than 5.3.3) version (or with the hack commented above). At very early stages (before the environment checks) you should get a message about 5.3.3 being required for Moodle 2.5.

      2) In a running Moodle site, go to the admin/index.php page, change your PHP version to older (than 5.3.3) version (or with the hack commented above). Every page loaded should lead to message about 5.3.3 being required for Moodle 2.5

      3) In a running Moodle site, run any CLI script currently using config.php (basically any of the admin/cli ones). With your PHP version being older than 5.3.3 or the hack commented above in place, you should get a message about 5.3.3 being required for Moodle 2.5.

      Note that, for future checks/testing... I've created MDL-39007 about to unify all those checks.

      Show
      Note to the testers, if switching to older version is not viable, alternatively you can always look for all the lines changed in the patch and replace the 5.3.3 there by your current PHP version + 1, to force the tests to fail. 1) Try installing Moodle, both with the web and the cli installers with an older (than 5.3.3) version (or with the hack commented above). At very early stages (before the environment checks) you should get a message about 5.3.3 being required for Moodle 2.5. 2) In a running Moodle site, go to the admin/index.php page, change your PHP version to older (than 5.3.3) version (or with the hack commented above). Every page loaded should lead to message about 5.3.3 being required for Moodle 2.5 3) In a running Moodle site, run any CLI script currently using config.php (basically any of the admin/cli ones). With your PHP version being older than 5.3.3 or the hack commented above in place, you should get a message about 5.3.3 being required for Moodle 2.5. Note that, for future checks/testing... I've created MDL-39007 about to unify all those checks.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      49115

      Description

      Once MDL-37033 has landed, with changes in the PHP requirements raised from 5.3.2 to 5.3.3 we need to change all the harcoded requirements in codebase (installers & setup.php) to point to the new version.

      Note that, in the description of MDL-37033, this has been commented, so future clones of that issue will have the note present to avoid forgetting it.

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          (sent to integration)

          Show
          Eloy Lafuente (stronk7) added a comment - (sent to integration)
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks!

          Show
          Dan Poltawski added a comment - Integrated, thanks!
          Hide
          Dan Poltawski added a comment -

          Andrew has confirmed that it passes. Yay.

          Show
          Dan Poltawski added a comment - Andrew has confirmed that it passes. Yay.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Your awesome contributions are now part of Moodle, your fav LMS out there.

          Closing this as fixed.

          Many thanks for all the hard work, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Your awesome contributions are now part of Moodle, your fav LMS out there. Closing this as fixed. Many thanks for all the hard work, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: