Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39007

Unify all the places performing a PHP version check

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.5
    • Fix Version/s: None
    • Component/s: Installation
    • Labels:
    • Affected Branches:
      MOODLE_25_STABLE

      Description

      Detected while fixing MDL-39006 and MDL-42931.

      Right now, apart from the environmental checks of the PHP version, there are a lot of code duplicated performing the same PHP version check here and there (installers, some cli utilities, setup.php...).

      Some of them are 100% redundant and others could be put under a unique function somewhere instead of having to modify manually all them. Ideally the version should be read from some common place too.

      That is, a little improvement for 2.6.

      Ciao

        Attachments

          Issue Links

          duplicates

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-57432 Decide Moodle 3.4 requirements and push them to environment.xml (due date: 29/05/2017)

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-54901 Decide Moodle 3.3 requirements and push them to environment.xml (due date: 5/12/2016)

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-57432 Decide Moodle 3.4 requirements and push them to environment.xml (due date: 29/05/2017)

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-53019 Decide Moodle 3.2 requirements and push them to environment.xml (due date: 13/06/2016)

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39006 Move on to 5.3.3 in harcoded dependencies for Moodle 2.5

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              • Assignee:
                poltawski Dan Poltawski
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Participants:
                Component watchers:
                Matteo Scaramuccia, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                5 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: