Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. As ADMIN ensure that 'Theme Designer Mode' is DISABLED in Site Administration > Appearance > Themes > Theme settings.
      2. Using Theme selector TEST that Bootstrap theme can not be seen, same too for Canvas and Base themes.
      3. Next ENABLE Theme Designer Mode as in Theme settings.
      4. Using Theme selector TEST that Bootstrap theme is VISIBLE (ie: selectable).
      Show
      As ADMIN ensure that 'Theme Designer Mode' is DISABLED in Site Administration > Appearance > Themes > Theme settings. Using Theme selector TEST that Bootstrap theme can not be seen, same too for Canvas and Base themes. Next ENABLE Theme Designer Mode as in Theme settings. Using Theme selector TEST that Bootstrap theme is VISIBLE (ie: selectable).
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-39010_master

      Description

      Since Bootstrap is a new parent theme, it should not be selectable via Theme selector screen. By setting this to true in theme/bootstrap/config.php it will only be shown if theme designer mode is switched on.

      $THEME->hidefromselector = true;
      

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            dougiamas Martin Dougiamas added a comment - - edited

            For testing and bug fixing in 2.5, I suggest this lands at the same time as a 'standardbs' theme.

            Show
            dougiamas Martin Dougiamas added a comment - - edited For testing and bug fixing in 2.5, I suggest this lands at the same time as a 'standardbs' theme.
            Hide
            lazydaisy Mary Evans added a comment -

            OK thanks

            Show
            lazydaisy Mary Evans added a comment - OK thanks
            Hide
            nebgor Aparup Banerjee added a comment -

            waiting for linked 'standardbs' theme

            Show
            nebgor Aparup Banerjee added a comment - waiting for linked 'standardbs' theme
            Hide
            dougiamas Martin Dougiamas added a comment -

            Actually what is the rationale for this? Why can't it be selectable?

            Show
            dougiamas Martin Dougiamas added a comment - Actually what is the rationale for this? Why can't it be selectable?
            Hide
            roelmann Richard Oelmann added a comment -

            I think the rationale was that, if the main bootstrap theme is to act like base/canvas do at the moment it is a foundation theme that others build on rather than one that is selected directly, and that there should be a 'standard' theme which becomes the one which is actually used.
            That said the bootstrap theme has so much more in it already than base/canvas do, it is almost like a 'standard' theme in and of itself anyway.
            As Mary has commented to me in other threads, maybe we (I ) need to reconsider how we think about themes, and maybe this is where to start - that we don't actually need a 'bootstrapstandard' by making the actual bootstrap theme selectable anyway - it becomes more like the existing standard than the existing base/canvas - just that it doesn't need a hidden parent theme??? The settings like the ones Felix worked on and the one's David was talking about in another thread would then fit into the main bootstrap theme rather than a new standardbs theme.
            The only thing I would say then is that somewhere - in a read me file or such it is made even more clear to themers than it already is that the theme should be cloned not edited direct
            Just a thought - anyone?

            Show
            roelmann Richard Oelmann added a comment - I think the rationale was that, if the main bootstrap theme is to act like base/canvas do at the moment it is a foundation theme that others build on rather than one that is selected directly, and that there should be a 'standard' theme which becomes the one which is actually used. That said the bootstrap theme has so much more in it already than base/canvas do, it is almost like a 'standard' theme in and of itself anyway. As Mary has commented to me in other threads, maybe we (I ) need to reconsider how we think about themes, and maybe this is where to start - that we don't actually need a 'bootstrapstandard' by making the actual bootstrap theme selectable anyway - it becomes more like the existing standard than the existing base/canvas - just that it doesn't need a hidden parent theme??? The settings like the ones Felix worked on and the one's David was talking about in another thread would then fit into the main bootstrap theme rather than a new standardbs theme. The only thing I would say then is that somewhere - in a read me file or such it is made even more clear to themers than it already is that the theme should be cloned not edited direct Just a thought - anyone?
            Hide
            dougiamas Martin Dougiamas added a comment -

            Not cloned!

            Any theme based on bootstrap MUST inherit everything it has and only add new stuff on top. This is the only reason that I can see for a "simple" theme, to act as an example to clone.

            Show
            dougiamas Martin Dougiamas added a comment - Not cloned! Any theme based on bootstrap MUST inherit everything it has and only add new stuff on top. This is the only reason that I can see for a "simple" theme, to act as an example to clone.
            Hide
            bawjaws David Scotson added a comment -

            We could port one of the existing other themes (or a popular 3rd party one) as an example of how to easily change the look of the Bootstrap theme with just CSS e.g. "Bootstrap Fusion" or "Bootstrap Arialist", then Simple could just be folded back in to Bootstrap.

            Show
            bawjaws David Scotson added a comment - We could port one of the existing other themes (or a popular 3rd party one) as an example of how to easily change the look of the Bootstrap theme with just CSS e.g. "Bootstrap Fusion" or "Bootstrap Arialist", then Simple could just be folded back in to Bootstrap.
            Hide
            dougiamas Martin Dougiamas added a comment - - edited

            On thinking more about it I'm back to hiding bootstrap totally from people. It's core code really, written by Moodle developers with command-line tools, and we should not be encouraging people to copy it in any way, anymore than they would copy Moodle libraries.

            So if I can make an executive decisin to keep things moving, let's hide /theme/bootstrap as this patch describes, introduce /theme/simple to be the plainest, simplest most well-documented example of a bootstrap theme for people to both use and copy (MDL-39021) and if there's any time for more bootstrap themes then great, but let's not get bogged in it now, they should be in moodle.org plugins database anyway.

            Show
            dougiamas Martin Dougiamas added a comment - - edited On thinking more about it I'm back to hiding bootstrap totally from people. It's core code really, written by Moodle developers with command-line tools, and we should not be encouraging people to copy it in any way, anymore than they would copy Moodle libraries. So if I can make an executive decisin to keep things moving, let's hide /theme/bootstrap as this patch describes, introduce /theme/simple to be the plainest, simplest most well-documented example of a bootstrap theme for people to both use and copy ( MDL-39021 ) and if there's any time for more bootstrap themes then great, but let's not get bogged in it now, they should be in moodle.org plugins database anyway.
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated to master - thanks Mary

            Show
            poltawski Dan Poltawski added a comment - Integrated to master - thanks Mary
            Hide
            poltawski Dan Poltawski added a comment -

            Tested and passed during integration - thanks

            Show
            poltawski Dan Poltawski added a comment - Tested and passed during integration - thanks
            Hide
            poltawski Dan Poltawski added a comment -

            (note that theme/simple has landed in MDL-39021)

            Show
            poltawski Dan Poltawski added a comment - (note that theme/simple has landed in MDL-39021 )
            Hide
            poltawski Dan Poltawski added a comment -

            Blooming Marvelous! It's time for a knees up - your changes are upstream!

            Thanks for making Moodle better!

            Toodle pip

            Show
            poltawski Dan Poltawski added a comment - Blooming Marvelous! It's time for a knees up - your changes are upstream! Thanks for making Moodle better! Toodle pip

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13