Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39020

Calendar externallib unit tests are being skipped and are failing.

    Details

      Description

      The test file has the wrong suffix (currently _tests.php - should be _test.php). This causes it to be skipped by phpunit when running all the tests. I filed a MDLSITE bug about detecting the missing tests (but not quite sure if that is possible). This bug is just about fixing the calendar unit tests.

      (+1 for backporting the fix)

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              damyon Damyon Wiese added a comment -

              The fail is: core_calendar_external_testcase::test_create_calendar_events
              dml_exception: Comparisons of text column conditions are not allowed. Please use sql_compare_text() in your query.

              Which is a fail in the test - not the calendar.

              Show
              damyon Damyon Wiese added a comment - The fail is: core_calendar_external_testcase::test_create_calendar_events dml_exception: Comparisons of text column conditions are not allowed. Please use sql_compare_text() in your query. Which is a fail in the test - not the calendar.
              Hide
              ankit_frenz Ankit Agarwal added a comment - - edited

              Unit tests broke because event name was changed from varchar to longtext, cannot seem to find the MDL
              edit:- issue was MDL-38344

              Show
              ankit_frenz Ankit Agarwal added a comment - - edited Unit tests broke because event name was changed from varchar to longtext, cannot seem to find the MDL edit:- issue was MDL-38344
              Hide
              abgreeve Adrian Greeve added a comment -

              [Y] Syntax
              [Y] Whitespace
              [Y] Output
              [-] Language
              [Y] Databases
              [Y] Testing
              [-] Security
              [-] Documentation
              [Y] Git
              [Y] Sanity check

              Seems legit.

              Please proceed.

              Thanks.

              Show
              abgreeve Adrian Greeve added a comment - [Y] Syntax [Y] Whitespace [Y] Output [-] Language [Y] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check Seems legit. Please proceed. Thanks.
              Hide
              ankit_frenz Ankit Agarwal added a comment -

              Thanks for the review Adrian.
              Submitting.

              Show
              ankit_frenz Ankit Agarwal added a comment - Thanks for the review Adrian. Submitting.
              Hide
              marina Marina Glancy added a comment -

              Thanks guys, this has been integrated in 2.5 and master

              Show
              marina Marina Glancy added a comment - Thanks guys, this has been integrated in 2.5 and master
              Hide
              dmonllao David Monllaó added a comment -

              It passes, whole phpunit suite ran in 25 and master including

              Starting test 'core_calendar_external_testcase::test_create_calendar_events'.
              .
              Starting test 'core_calendar_external_testcase::test_delete_calendar_events'.
              .
              Starting test 'core_calendar_external_testcase::test_get_calendar_events'.
              .
              Starting test 'core_calendar_external_testcase::test_core_create_calendar_events'.
              

              Show
              dmonllao David Monllaó added a comment - It passes, whole phpunit suite ran in 25 and master including Starting test 'core_calendar_external_testcase::test_create_calendar_events'. . Starting test 'core_calendar_external_testcase::test_delete_calendar_events'. . Starting test 'core_calendar_external_testcase::test_get_calendar_events'. . Starting test 'core_calendar_external_testcase::test_core_create_calendar_events'.
              Hide
              damyon Damyon Wiese added a comment -

              a single bug fix
              a drop in a waterfall
              hear the mighty roar

              Thanks for your contribution!

              Show
              damyon Damyon Wiese added a comment - a single bug fix a drop in a waterfall hear the mighty roar Thanks for your contribution!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Sep/13