Moodle
  1. Moodle
  2. MDL-39022

bad encoding concat in mssql driver

    Details

      Description

      $arr[$key] = ' CAST(' . $ele . ' AS VARCHAR(255)) ';

      should be NVARCHAR it seems

      dml_testcase::test_sql_concat
      Failed asserting that two strings are equal.
      — Expected
      +++ Actual
      @@ @@
      -'name├í├®├¡├│├║name3'
      +'nameßÚݾ·name3'

      C:\server\workspace\moodle25\lib\dml\tests\dml_test.php:3787
      C:\server\workspace\moodle25\lib\phpunit\classes\database_driver_testcase.php:14
      3

      To re-run:
      C:\server\workspace\moodle25\vendor\phpunit\phpunit\composer\bin\phpunit dml_testcase lib\dml\tests\dml_test.php

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Petr Skoda added a comment -

            No idea if that is correct, but the tests pass now...

            Any objections Eloy?

            Show
            Petr Skoda added a comment - No idea if that is correct, but the tests pass now... Any objections Eloy?
            Hide
            Eloy Lafuente (stronk7) added a comment -

            nope, perfect.

            Show
            Eloy Lafuente (stronk7) added a comment - nope, perfect.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated (23, 24 & master), thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
            Hide
            Rajesh Taneja added a comment -

            Thanks for fixing this Petr,

            Tested this as part of MDL-39024.

            Show
            Rajesh Taneja added a comment - Thanks for fixing this Petr, Tested this as part of MDL-39024 .
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Your awesome contributions are now part of Moodle, your fav LMS out there.

            Closing this as fixed.

            Many thanks for all the hard work, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Your awesome contributions are now part of Moodle, your fav LMS out there. Closing this as fixed. Many thanks for all the hard work, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: