Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39023

Circular dependency in parentlanguage definition may easily lead to infinitive loops

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • 2.3.7, 2.4.4
    • 2.1.10, 2.2.9, 2.3.6, 2.4.3, 2.5
    • Language
    • MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • MOODLE_23_STABLE, MOODLE_24_STABLE
    • MDL-39023-parentlang
    • Hide

      Testing difficulty: medium (requires direct access to moodledata)

      1. Install some language pack (let's call it 'xx')
      2. Edit $CFG->dataroot/lang/xx/langconfig.php
      3. Change/add the parent language declaration and point it to the language itself:

      $string['parentlanguage'] = 'xx';

      4. TEST: Make sure the site (e.g. the front page) is still available (it died in infinitive loop before).

      Show
      Testing difficulty: medium (requires direct access to moodledata) 1. Install some language pack (let's call it 'xx') 2. Edit $CFG->dataroot/lang/xx/langconfig.php 3. Change/add the parent language declaration and point it to the language itself: $string['parentlanguage'] = 'xx'; 4. TEST: Make sure the site (e.g. the front page) is still available (it died in infinitive loop before).

      This was just observed at lang.moodle.org - the maintainer of he_kids language pack set the parentlanguage of it to the he_kids itself (instead of expected he). This creates circular dependency problem in string_manager::get_language_dependecies() and the site with the lang installed dies in infinitive loop hell.

            mudrd8mz David Mudrák (@mudrd8mz)
            mudrd8mz David Mudrák (@mudrd8mz)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.