Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39023

Circular dependency in parentlanguage definition may easily lead to infinitive loops

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1.10, 2.2.9, 2.3.6, 2.4.3, 2.5
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Language
    • Labels:
    • Testing Instructions:
      Hide

      Testing difficulty: medium (requires direct access to moodledata)

      1. Install some language pack (let's call it 'xx')
      2. Edit $CFG->dataroot/lang/xx/langconfig.php
      3. Change/add the parent language declaration and point it to the language itself:

      $string['parentlanguage'] = 'xx';

      4. TEST: Make sure the site (e.g. the front page) is still available (it died in infinitive loop before).

      Show
      Testing difficulty: medium (requires direct access to moodledata) 1. Install some language pack (let's call it 'xx') 2. Edit $CFG->dataroot/lang/xx/langconfig.php 3. Change/add the parent language declaration and point it to the language itself: $string['parentlanguage'] = 'xx'; 4. TEST: Make sure the site (e.g. the front page) is still available (it died in infinitive loop before).
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39023-parentlang
    • Pull Master Diff URL:

      Description

      This was just observed at lang.moodle.org - the maintainer of he_kids language pack set the parentlanguage of it to the he_kids itself (instead of expected he). This creates circular dependency problem in string_manager::get_language_dependecies() and the site with the lang installed dies in infinitive loop hell.

        Attachments

          Issue Links

          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDLSITE-2194 html error 500 on lang.moodle.org

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              mudrd8mz David Mudrák (@mudrd8mz)
              Reporter:
              mudrd8mz David Mudrák (@mudrd8mz)
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              David Mudrák (@mudrd8mz), Helen Foster, Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/May/13