That might you your expectation, but then I guess you do not use a screen-reader. Have a read of http://www.brucelawson.co.uk/2009/the-accessibility-of-html-5-autofocus/ and http://stackoverflow.com/questions/2180645/is-automatically-assigning-focus-bad-for-accessibility.

Therefore, it is not clear to me that we should do this.

I read the postings on the link you provided. While I have no experience with ScreenReaders, there seems to be no conflict from the comments I read about possible issues. There is only one field on the entire page (the one for entering the password) so there would be no confusion (nothing not intuitive or unexpected going on there). The screen would not scroll down to any unusual place (which was one of the other comments made there). Just my 2 cents.

Thanks to Tim for showing simple way!

Review comments:

1. The commit comment does not mention the tracker issue id. See http://docs.moodle.org/dev/Commit_cheat_sheet#Provide_clear_commit_messages for the preferred format for commit messages.

2. The code could be better. $attributes= is meaningless. I would prefer to use the structured form array('autofocus' => 'true') rather than the string form.

3. https://moodle.org/plugins/view.php?plugin=local_codechecker is your friend.

I would make the changes and submit again!

Changes made as per suggestion!

1. The code is now almost perfect, but not quite. According to the Moodle coding style (http://docs.moodle.org/dev/Coding_style) there must be a space after the comma (,). Yes, we are really picky about these things. That is why we made the codechecker plugin.

2. See the comment I made about commit messages in the other bug.

1. Space added!

2. Commit message short!

Good. We are very nearly there.

I am wondering if it would be clearer to say:

MDL-39029 quiz password: autofocus feature added

What do you think?

Yeah Would be much better!

Done with it!

Would you like to write some testing instructions?

Yes would definetly like to do so!

Thanks Jayesh. Submitting for integration.

Integrated to master - thanks Jayesh!

Thanks for fixing this Jayesh,

Works as mentioned in test instructions.

FYI:
Getting setType warning on startattempt page.

Did you remember to call setType() for 'cmid'? Defaulting to PARAM_RAW cleaning.•line 1289 of /lib/formslib.php: call to debugging()
•line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
•line 202 of /lib/formslib.php: call to moodleform->_process_submission()
•line 338 of /mod/quiz/accessmanager.php: call to moodleform->moodleform()
•line 134 of /mod/quiz/startattempt.php: call to quiz_access_manager->get_preflight_check_form()

@Tim let me know if you want me to create an issue for this. Can't find in MDL-34311

Rajesh, new tracker issue for that please.

Thanks Tim,

Created MDL-39186.

Blooming Marvelous! It's time for a knees up - your changes are upstream!

Thanks for making Moodle better!

Toodle pip