Moodle
  1. Moodle
  2. MDL-39033

Conditional availability: Available items dimmed to students

    Details

    • Testing Instructions:
      Hide

      0. Turn on completion tracking at course and site.
      1. Create a label and a forum. Set the forum to be available if the label is complete.
      2. Log in as student. Observe forum is correctly not available and its link is greyed out.
      3. Tick the box next to the label. The page reloads.

      EXPECTED: Forum should now be available and should not be greyed out.
      BEFORE FIX: Forum is available, but is greyed out (with classes 'dimmed conditionalhidden' on the link).

      Show
      0. Turn on completion tracking at course and site. 1. Create a label and a forum. Set the forum to be available if the label is complete. 2. Log in as student. Observe forum is correctly not available and its link is greyed out. 3. Tick the box next to the label. The page reloads. EXPECTED: Forum should now be available and should not be greyed out. BEFORE FIX: Forum is available, but is greyed out (with classes 'dimmed conditionalhidden' on the link).
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-39033-master
    • Rank:
      49149

      Description

      Item which is available to students shows as dimmed when it has a condition.

        Issue Links

          Activity

          Hide
          Sam Marshall added a comment -

          I've retested with current weekly release. This is now working (I don't know if it was ever actually broken, or just my misunderstanding). However, strangely, the forum is greyed out (even though it works) with classes 'dimmed conditionalhidden'. I would've thought those should only apply for teachers. Will investigate.

          Show
          Sam Marshall added a comment - I've retested with current weekly release. This is now working (I don't know if it was ever actually broken, or just my misunderstanding). However, strangely, the forum is greyed out (even though it works) with classes 'dimmed conditionalhidden'. I would've thought those should only apply for teachers. Will investigate.
          Hide
          Sam Marshall added a comment -

          This patch fixes the problem - we were showing items 'dimmed' to students when they have met the conditions to see the item. What it is supposed to do is to show them dimmed to teachers (so teachers know the item might not be available in general); for students, items only appear dimmed if you aren't allowed to access them.

          Show
          Sam Marshall added a comment - This patch fixes the problem - we were showing items 'dimmed' to students when they have met the conditions to see the item. What it is supposed to do is to show them dimmed to teachers (so teachers know the item might not be available in general); for students, items only appear dimmed if you aren't allowed to access them.
          Hide
          Michael de Raadt added a comment -

          This came up in a QA test. Thankfully there's a solution here. I've just promoted it.

          Show
          Michael de Raadt added a comment - This came up in a QA test. Thankfully there's a solution here. I've just promoted it.
          Hide
          Jason Fowler added a comment -

          Makes sense Sam. Code checks out.

          Submitting for integration

          Show
          Jason Fowler added a comment - Makes sense Sam. Code checks out. Submitting for integration
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks Sam - changes looked spot on and this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Sam - changes looked spot on and this has been integrated now.
          Hide
          Sam Hemelryk added a comment -

          Tested during integration review and will be tested again by MDLQA-5412.
          Marking as passed.

          Show
          Sam Hemelryk added a comment - Tested during integration review and will be tested again by MDLQA-5412 . Marking as passed.
          Hide
          Nicolas Martignoni added a comment -

          Test MDLQA-5412 passes too.

          Show
          Nicolas Martignoni added a comment - Test MDLQA-5412 passes too.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I feel myself really alone tonight! So was time to push your fixes upstream!

          "Lest we forget. We will remember them."

          Thanks and ciao!

          Show
          Eloy Lafuente (stronk7) added a comment - I feel myself really alone tonight! So was time to push your fixes upstream! "Lest we forget. We will remember them." Thanks and ciao!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: