Moodle
  1. Moodle
  2. MDL-39040

Database activity description is visible only in List and Search view

    Details

    • Testing Instructions:
      Hide
      1. Create a database activity
      2. Make sure to add something to the description.
      3. Click "Save and display".
      4. Add some fields
      5. Click on the templates tab and then click save template button.
      6. Click each of the following tabs:
        • "View list"
        • "View single"
        • "Search"
        • "Export"
        • "Templates"
        • "Fields"
        • "Presets"
        • Make sure that the description is below the title and above the tabs on each page.
      Show
      Create a database activity Make sure to add something to the description. Click "Save and display". Add some fields Click on the templates tab and then click save template button. Click each of the following tabs: "View list" "View single" "Search" "Export" "Templates" "Fields" "Presets" Make sure that the description is below the title and above the tabs on each page.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-39040-master
    • Rank:
      49158

      Description

      The description you enter when creating a database activity is visible when you click on the View List and Search tabs, but is not visible when using any other of the tabs. If a teacher enters detailed directions on how or what to add in an entry, the student will not be able to read them when they actually switch to Add Entry. Right now the only work around would be to duplicate the directions onto the Add Entry template.

        Activity

        Hide
        AL Rachels added a comment -

        It seems that it takes only one line of code to make the description visible when you click on the Add Entry tab. The line of code that needs to be added goes in:

        moodle/mod/data/edit.php

        echo $OUTPUT->box(format_module_intro('data', $data, $cm->id), 'generalbox', 'intro');

        Add the new line of code after line 252 for Moodle 2.2, 2.3, and 2.4. Add it after line 253 for Moodle 2.5. I have tried it in all four of these versions, and they all seem to work fine.

        Show
        AL Rachels added a comment - It seems that it takes only one line of code to make the description visible when you click on the Add Entry tab. The line of code that needs to be added goes in: moodle/mod/data/edit.php echo $OUTPUT->box(format_module_intro('data', $data, $cm->id), 'generalbox', 'intro'); Add the new line of code after line 252 for Moodle 2.2, 2.3, and 2.4. Add it after line 253 for Moodle 2.5. I have tried it in all four of these versions, and they all seem to work fine.
        Hide
        Rossiani Wijaya added a comment -

        Hi Adrian,

        The patch looks great.

        It would be great if you could also added to export, templates, fields and presets pages. That way it will keep the consistency for the pages.

        Thanks for fixing this issue.

        Rosie

        Show
        Rossiani Wijaya added a comment - Hi Adrian, The patch looks great. It would be great if you could also added to export, templates, fields and presets pages. That way it will keep the consistency for the pages. Thanks for fixing this issue. Rosie
        Hide
        Adrian Greeve added a comment -

        Thanks Rosie,

        I added the description to each page.

        Submitting for integration.

        Show
        Adrian Greeve added a comment - Thanks Rosie, I added the description to each page. Submitting for integration.
        Hide
        Dan Poltawski added a comment -

        Hi Adrian,

        This doesn't seem like a bug to me, unless i'm missing something, this has been like this since the beginning of time. Its also a ui_change, so i'm holding this for release.

        Feel free to campaign (to martin etc) to get this pushed into the release.

        Show
        Dan Poltawski added a comment - Hi Adrian, This doesn't seem like a bug to me, unless i'm missing something, this has been like this since the beginning of time. Its also a ui_change, so i'm holding this for release. Feel free to campaign (to martin etc) to get this pushed into the release.
        Hide
        Adrian Greeve added a comment -

        Hi Dan,

        No rush. I'm happy to wait until until after the release of 2.5.

        Show
        Adrian Greeve added a comment - Hi Dan, No rush. I'm happy to wait until until after the release of 2.5.
        Hide
        Sam Hemelryk added a comment -

        Thanks Adrian this has been integrated now.

        Show
        Sam Hemelryk added a comment - Thanks Adrian this has been integrated now.
        Hide
        Frédéric Massart added a comment -

        Passing, thanks! (The description also appeared in 'Add entry').

        Show
        Frédéric Massart added a comment - Passing, thanks! (The description also appeared in 'Add entry').
        Hide
        Marina Glancy added a comment -

        Thanks for your awesome work! This has now become a part of Moodle.

        Closing as fixed!

        Show
        Marina Glancy added a comment - Thanks for your awesome work! This has now become a part of Moodle. Closing as fixed!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: