Moodle
  1. Moodle
  2. MDL-39044

Replace strtolower in block/completionstatus with textlib::strtolower

    Details

    • Story Points:
      2
    • Rank:
      380
    • Sprint:
      FRONTEND Sprint 1

      Description

      Needs to be multibyte safe.

        Issue Links

          Activity

          Hide
          Damyon Wiese added a comment -

          Assigning as requested!

          Show
          Damyon Wiese added a comment - Assigning as requested!
          Hide
          Jason Fowler added a comment -

          Thanks Damyon, will get to work on this in the next sprint we have.

          Show
          Jason Fowler added a comment - Thanks Damyon, will get to work on this in the next sprint we have.
          Hide
          Jason Fowler added a comment -

          Unassigning myself from this issue, to allow for others to take it as it comes into the sprint backlogs in the future.

          Show
          Jason Fowler added a comment - Unassigning myself from this issue, to allow for others to take it as it comes into the sprint backlogs in the future.
          Hide
          Jason Fowler added a comment -

          Fixed, and pushed for peer review.

          Show
          Jason Fowler added a comment - Fixed, and pushed for peer review.
          Hide
          Ankit Agarwal added a comment -

          Hi Jason,
          +1 for integration. Two minor things:-

          1. There is typo in commit message (save => safe)
          2. Will be nice to have the testing instructions to actually test details.php with multibyte chars.

          Feel free to submit, once you have taken care of these.
          Cheers

          Show
          Ankit Agarwal added a comment - Hi Jason, +1 for integration. Two minor things:- There is typo in commit message (save => safe) Will be nice to have the testing instructions to actually test details.php with multibyte chars. Feel free to submit, once you have taken care of these. Cheers
          Hide
          Jason Fowler added a comment -

          Thanks Ankit, done, now pushing for integration.

          Show
          Jason Fowler added a comment - Thanks Ankit, done, now pushing for integration.
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks Jason, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Jason, this has been integrated now
          Hide
          Petr Škoda added a comment -

          Works fine here, btw this type of lang string concat and lowercasing is strongly discouraged, but that is a different problem...

          Show
          Petr Škoda added a comment - Works fine here, btw this type of lang string concat and lowercasing is strongly discouraged, but that is a different problem...
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Thanks for giving me joys and smiles
          Thanks for sharing my trouble's pile

          Thanks for wipeing the tears of my eye
          Thanks for showing me the glad view of sky

          Thanks for lending me your shoulders to lean
          Thanks for giving my words a proper mean

          Thanks for telling me the value of life
          Thanks for showing me the rules to survive

          Thanks for lending me the sympathetic ears
          Thanks for showing how much you care

          From all this what I mean in the end
          Is thanks for being my special friend.

          – Seema Chowdhury

          Sent upstream so... closing, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Thanks for giving me joys and smiles Thanks for sharing my trouble's pile Thanks for wipeing the tears of my eye Thanks for showing me the glad view of sky Thanks for lending me your shoulders to lean Thanks for giving my words a proper mean Thanks for telling me the value of life Thanks for showing me the rules to survive Thanks for lending me the sympathetic ears Thanks for showing how much you care From all this what I mean in the end Is thanks for being my special friend. – Seema Chowdhury Sent upstream so... closing, thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile