Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39044

Replace strtolower in block/completionstatus with textlib::strtolower

    Details

    • Testing Instructions:
      Hide
      1. Create a course
      2. Enable and configure course completion
      3. Add the course completion block
      4. Access the course as an Admin, Teacher, Student, and Guest and ensure the Completion block isn't broken
      5. Swap to a language that uses glyphs rather than latin letters (Chinese, Arabic, etc) and repeat Step 4.
      Show
      Create a course Enable and configure course completion Add the course completion block Access the course as an Admin, Teacher, Student, and Guest and ensure the Completion block isn't broken Swap to a language that uses glyphs rather than latin letters (Chinese, Arabic, etc) and repeat Step 4.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-39044-master
    • Sprint:
      FRONTEND Sprint 1
    • Story Points (Obsolete):
      2
    • Sprint:
      FRONTEND Sprint 1

      Description

      Needs to be multibyte safe.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            damyon Damyon Wiese added a comment -

            Assigning as requested!

            Show
            damyon Damyon Wiese added a comment - Assigning as requested!
            Hide
            phalacee Jason Fowler added a comment -

            Thanks Damyon, will get to work on this in the next sprint we have.

            Show
            phalacee Jason Fowler added a comment - Thanks Damyon, will get to work on this in the next sprint we have.
            Hide
            phalacee Jason Fowler added a comment -

            Unassigning myself from this issue, to allow for others to take it as it comes into the sprint backlogs in the future.

            Show
            phalacee Jason Fowler added a comment - Unassigning myself from this issue, to allow for others to take it as it comes into the sprint backlogs in the future.
            Hide
            phalacee Jason Fowler added a comment -

            Fixed, and pushed for peer review.

            Show
            phalacee Jason Fowler added a comment - Fixed, and pushed for peer review.
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Hi Jason,
            +1 for integration. Two minor things:-

            1. There is typo in commit message (save => safe)
            2. Will be nice to have the testing instructions to actually test details.php with multibyte chars.

            Feel free to submit, once you have taken care of these.
            Cheers

            Show
            ankit_frenz Ankit Agarwal added a comment - Hi Jason, +1 for integration. Two minor things:- There is typo in commit message (save => safe) Will be nice to have the testing instructions to actually test details.php with multibyte chars. Feel free to submit, once you have taken care of these. Cheers
            Hide
            phalacee Jason Fowler added a comment -

            Thanks Ankit, done, now pushing for integration.

            Show
            phalacee Jason Fowler added a comment - Thanks Ankit, done, now pushing for integration.
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Jason, this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Jason, this has been integrated now
            Hide
            skodak Petr Skoda added a comment -

            Works fine here, btw this type of lang string concat and lowercasing is strongly discouraged, but that is a different problem...

            Show
            skodak Petr Skoda added a comment - Works fine here, btw this type of lang string concat and lowercasing is strongly discouraged, but that is a different problem...
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Thanks for giving me joys and smiles
            Thanks for sharing my trouble's pile

            Thanks for wipeing the tears of my eye
            Thanks for showing me the glad view of sky

            Thanks for lending me your shoulders to lean
            Thanks for giving my words a proper mean

            Thanks for telling me the value of life
            Thanks for showing me the rules to survive

            Thanks for lending me the sympathetic ears
            Thanks for showing how much you care

            From all this what I mean in the end
            Is thanks for being my special friend.

            – Seema Chowdhury

            Sent upstream so... closing, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Thanks for giving me joys and smiles Thanks for sharing my trouble's pile Thanks for wipeing the tears of my eye Thanks for showing me the glad view of sky Thanks for lending me your shoulders to lean Thanks for giving my words a proper mean Thanks for telling me the value of life Thanks for showing me the rules to survive Thanks for lending me the sympathetic ears Thanks for showing how much you care From all this what I mean in the end Is thanks for being my special friend. – Seema Chowdhury Sent upstream so... closing, thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/Jul/13

                  Agile