Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39049

Error when awarding badge immediately after adding it

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Badges
    • Labels:
    • Testing Instructions:
      Hide

      1. Log in as a teacher and go to Settings > Course admin > Badges > Add a new badge
      2. Create a new badge
      3. Add criteria "Manual issue by role". Select "teacher". Save criteria.
      4. Enable access.
      5. Go to "Recipients" tab and click "Award badge" button.
      6. Select students on the right to award badge.
      7. Click "Award badge".
      8. Selected users should appear in the list to the left. No error message should appear.
      9. Go back to the Recipients tab. Previously selected users should in the table of badge recipients.

      Show
      1. Log in as a teacher and go to Settings > Course admin > Badges > Add a new badge 2. Create a new badge 3. Add criteria "Manual issue by role". Select "teacher". Save criteria. 4. Enable access. 5. Go to "Recipients" tab and click "Award badge" button. 6. Select students on the right to award badge. 7. Click "Award badge". 8. Selected users should appear in the list to the left. No error message should appear. 9. Go back to the Recipients tab. Previously selected users should in the table of badge recipients.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
      git@github.com:totara/openbadges.git
    • Pull Master Branch:
      MDL-39049_master

      Description

      As a teacher in a course if you add a new badge and then try to award it from the Recipients tab you get the following error message.

      Debug info: 
      Error code: missingparam
      Stack trace:
      line 476 of /lib/setuplib.php: moodle_exception thrown
      line 532 of /lib/moodlelib.php: call to print_error()
      line 31 of /badges/award.php: call to required_param()
      

      If however, you save it and go back to Course admin>Manage badges and award by clicking the award icon, you are then able to award the badge.

      Steps to reproduce:
      1. As a teacher go to Settings>Course admin>Badges>Add a new badge
      2. Add a new badge
      3. Add criteria "manual issue by role>teacher" and enable access.
      4. Click the "Recipients" tab and the "award badge" button.
      5. Add a student from the right over to the left. Error message appears.
      6. Go back to Settings>Course admin>Badges>Manage badges
      7. Click the "award badge" icon to get back to that same screen and try to award a student the badge again. It works.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13