Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39050

Quiz access rule plugins settings.php files should just work

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide
      1. Look in under Admin -> Plugins -> Activity modules -> Quiz. That should be a single settings page. Check that it works.
      2. Install https://github.com/moodleou/moodle-quizaccess_safeexambrowser
      3. Look in under Admin -> Plugins -> Activity modules -> Quiz. That should now be a category, with two pages under it: General settings and Safe Exam Browser quiz access rule. Check that they both work.
      Show
      Look in under Admin -> Plugins -> Activity modules -> Quiz. That should be a single settings page. Check that it works. Install https://github.com/moodleou/moodle-quizaccess_safeexambrowser Look in under Admin -> Plugins -> Activity modules -> Quiz. That should now be a category, with two pages under it: General settings and Safe Exam Browser quiz access rule. Check that they both work.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      There is code in mod/quiz/settings.php to include settings for any quiz reports. We need the same for access rule plugins.

        Gliffy Diagrams

          Activity

          Hide
          timhunt Tim Hunt added a comment -

          Submitting for integration.

          Show
          timhunt Tim Hunt added a comment - Submitting for integration.
          Hide
          poltawski Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          damyon Damyon Wiese added a comment -

          Hmm.. stretching "bug" even further here.

          I would (just) allow this except that this will change the UI on stable branches which is not allowed. I can see that you have changed from get_string('xxxreport', 'xxx') to get_string('pluginname', 'xxx') for the grade reports which will slightly change the names of the pages in the admin tree. Can you take this out and then I would (just) agree to backport this "bug" (I can see it is important for your contrib module).

          Thanks!

          Show
          damyon Damyon Wiese added a comment - Hmm.. stretching "bug" even further here. I would (just) allow this except that this will change the UI on stable branches which is not allowed. I can see that you have changed from get_string('xxxreport', 'xxx') to get_string('pluginname', 'xxx') for the grade reports which will slightly change the names of the pages in the admin tree. Can you take this out and then I would (just) agree to backport this "bug" (I can see it is important for your contrib module). Thanks!
          Hide
          timhunt Tim Hunt added a comment -

          Sure, I will happily take that out. I just unthinkingly normalised what looked like some legacy code. If I want to change that, it should of course be done as a separate issue, and documented in upgrade.txt, etc.

          Expect a new patch in a few hours. Thanks.

          Show
          timhunt Tim Hunt added a comment - Sure, I will happily take that out. I just unthinkingly normalised what looked like some legacy code. If I want to change that, it should of course be done as a separate issue, and documented in upgrade.txt, etc. Expect a new patch in a few hours. Thanks.
          Hide
          timhunt Tim Hunt added a comment -

          Right, commits amended. Ready for integration again.

          Show
          timhunt Tim Hunt added a comment - Right, commits amended. Ready for integration again.
          Hide
          damyon Damyon Wiese added a comment -

          Thanks Tim,

          Integrated to 23, 24 and master branches.

          I had to add a fix for the 23 branch - $module->is_enabled() is not in that version.

          Show
          damyon Damyon Wiese added a comment - Thanks Tim, Integrated to 23, 24 and master branches. I had to add a fix for the 23 branch - $module->is_enabled() is not in that version.
          Hide
          fred Frédéric Massart added a comment -

          Passing, thanks!

          Show
          fred Frédéric Massart added a comment - Passing, thanks!
          Hide
          timhunt Tim Hunt added a comment -

          Thanks Damyon.

          Show
          timhunt Tim Hunt added a comment - Thanks Damyon.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          I feel myself really alone tonight! So was time to push your fixes upstream!

          "Lest we forget. We will remember them."

          Thanks and ciao!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - I feel myself really alone tonight! So was time to push your fixes upstream! "Lest we forget. We will remember them." Thanks and ciao!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/May/13