Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39054

Hard-coded string in statistics_question_table.php

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.3.6, 2.4.3, 2.5
          • Fix Version/s: 2.3.7, 2.4.4
          • Component/s: Language, Quiz
          • Labels:
          • Testing Instructions:
            Hide

            1. Create a quiz containing one matching question.
            2. Attempt this quiz as two different students.
            3. As teacher, go to the quiz statistics report, and look at the detailed statistics for the matching question.
            4. Verify that in the Analysis of responses, the Part of question column name is still displayed correctly.

            Show
            1. Create a quiz containing one matching question. 2. Attempt this quiz as two different students. 3. As teacher, go to the quiz statistics report, and look at the detailed statistics for the matching question. 4. Verify that in the Analysis of responses, the Part of question column name is still displayed correctly.
          • Difficulty:
            Easy
          • Affected Branches:
            MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
          • Fixed Branches:
            MOODLE_23_STABLE, MOODLE_24_STABLE
          • Pull from Repository:
          • Pull Master Branch:
          • Pull Master Diff URL:

            Description

            I just found a hard-coded English table header in
            mod/quiz/report/statistics/statistics_question_table.php line 77
            of Moodle 2.5 (2.5dev (Build: 20130322)):

            if ($responesstats->has_subparts())

            { $columns[] = 'part'; $headers[] = 'Part of question'; }

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  timhunt Tim Hunt added a comment -

                  Code change good.

                  The commit comment is still not right. When you look at https://github.com/jacks92/moodle/compare/master...MDL-39054 (or when you use the git log --oneline command) you need to see what the change is.

                  I suggest a commit comment like:

                  MDL-39054 quiz statistics: hard-coded text to lang file

                  I think that for a simple change like this, you don't need to give any more details than that.

                  Show
                  timhunt Tim Hunt added a comment - Code change good. The commit comment is still not right. When you look at https://github.com/jacks92/moodle/compare/master...MDL-39054 (or when you use the git log --oneline command) you need to see what the change is. I suggest a commit comment like: MDL-39054 quiz statistics: hard-coded text to lang file I think that for a simple change like this, you don't need to give any more details than that.
                  Hide
                  Permalink
                  jacks92 Jayesh Anandani added a comment -

                  Commit message changed!

                  Show
                  jacks92 Jayesh Anandani added a comment - Commit message changed!
                  Hide
                  Permalink
                  timhunt Tim Hunt added a comment -

                  Doh! you carefully copied my mistake. I should have written "MDL-39054 quiz statistics: move hard-coded text to lang file".

                  Can you be bothered to cahgne it again? I'm sorry, this was my mistake.

                  Show
                  timhunt Tim Hunt added a comment - Doh! you carefully copied my mistake. I should have written " MDL-39054 quiz statistics: move hard-coded text to lang file". Can you be bothered to cahgne it again? I'm sorry, this was my mistake.
                  Hide
                  Permalink
                  jacks92 Jayesh Anandani added a comment -

                  No worries! My mistake sir! Edited!

                  Show
                  jacks92 Jayesh Anandani added a comment - No worries! My mistake sir! Edited!
                  Hide
                  Permalink
                  timhunt Tim Hunt added a comment -

                  Thanks. Submitting for integration now.

                  Note that, when an issue is submitted for integraions, we need to provide some Testing instructions. It is helpful if you write the testing instructions before you submti a patch for review.

                  Show
                  timhunt Tim Hunt added a comment - Thanks. Submitting for integration now. Note that, when an issue is submitted for integraions, we need to provide some Testing instructions. It is helpful if you write the testing instructions before you submti a patch for review.
                  Hide
                  Permalink
                  jacks92 Jayesh Anandani added a comment -

                  Will take care of that!

                  Show
                  jacks92 Jayesh Anandani added a comment - Will take care of that!
                  Hide
                  Permalink
                  poltawski Dan Poltawski added a comment -

                  Looks like this is present in stable versions, so I have cherry-picked it back.

                  Thanks a lot Jayesh!

                  Show
                  poltawski Dan Poltawski added a comment - Looks like this is present in stable versions, so I have cherry-picked it back. Thanks a lot Jayesh!
                  Hide
                  Permalink
                  rajeshtaneja Rajesh Taneja added a comment -

                  Thanks for fixing this, Jayesh.

                  Works as expected.

                  Show
                  rajeshtaneja Rajesh Taneja added a comment - Thanks for fixing this, Jayesh. Works as expected.
                  Hide
                  Permalink
                  poltawski Dan Poltawski added a comment -

                  Blooming Marvelous! It's time for a knees up - your changes are upstream!

                  Thanks for making Moodle better!

                  Toodle pip

                  Show
                  poltawski Dan Poltawski added a comment - Blooming Marvelous! It's time for a knees up - your changes are upstream! Thanks for making Moodle better! Toodle pip

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      3 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        13/May/13