Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.6, 2.4.3
    • Fix Version/s: 2.5
    • Component/s: Workshop
    • Labels:
    • Testing Instructions:
      Hide

      Testing difficulty: easy

      1. Make sure you have debugging messages display enabled.
      2. Prepare a workshop activity with at least one student, the workshop must be in No groups mode.
      3. Let the student submit their work.
      4. Use the Random allocator tool.
      5. TEST: Make sure no "Did you remember to call setType() for ..." is displayed.
      Show
      Testing difficulty: easy Make sure you have debugging messages display enabled. Prepare a workshop activity with at least one student, the workshop must be in No groups mode. Let the student submit their work. Use the Random allocator tool. TEST: Make sure no "Did you remember to call setType() for ..." is displayed.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39059-workshop-settype

      Description

      Thanks to the new debugging message, undefined param type has been spotted in workshop random allocator method.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            David Mudrak added a comment -

            Submitting for integration. Thanks for this debugging message Dan Poltawski!

            Show
            David Mudrak added a comment - Submitting for integration. Thanks for this debugging message Dan Poltawski !
            Hide
            Dan Poltawski added a comment -

            Integrated to master - thanks David

            Show
            Dan Poltawski added a comment - Integrated to master - thanks David
            Hide
            Dan Poltawski added a comment -

            Hi David,

            I found another one whilst testing:
            Did you remember to call setType() for 'example'? Defaulting to PARAM_RAW cleaning.
            line 1289 of /lib/formslib.php: call to debugging()
            line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
            line 202 of /lib/formslib.php: call to moodleform->_process_submission()
            line 158 of /mod/workshop/submission.php: call to moodleform->moodleform()

            Show
            Dan Poltawski added a comment - Hi David, I found another one whilst testing: Did you remember to call setType() for 'example'? Defaulting to PARAM_RAW cleaning. line 1289 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 158 of /mod/workshop/submission.php: call to moodleform->moodleform()
            Hide
            Dan Poltawski added a comment -

            However, I tested the random allocator and that was good, so this one could be done in a new issue if necesary.

            Show
            Dan Poltawski added a comment - However, I tested the random allocator and that was good, so this one could be done in a new issue if necesary.
            Hide
            Dan Poltawski added a comment -

            Created MDL-39081 for that so we can continue.

            Show
            Dan Poltawski added a comment - Created MDL-39081 for that so we can continue.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Your awesome contributions are now part of Moodle, your fav LMS out there.

            Closing this as fixed.

            Many thanks for all the hard work, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Your awesome contributions are now part of Moodle, your fav LMS out there. Closing this as fixed. Many thanks for all the hard work, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: