Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39060

Backup/restore base_task class sets nonexistant class field.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.3, 3.3.3, 3.4, 3.5
    • Fix Version/s: 3.3.6, 3.4.3
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide

      Testing steps:

      1. As Admin, create / use a Course
      2. Add some activities / content to the Course
      3. Enrol some Users
      4. Perform backup of Course to ensure the backup is successful
      5. Perform restoration of Course using the backup generated (in step 4), and ensure the restoration is successful
      Show
      Testing steps: As Admin, create / use a Course Add some activities / content to the Course Enrol some Users Perform backup of Course to ensure the backup is successful Perform restoration of Course using the backup generated (in step 4), and ensure the restoration is successful
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull Master Branch:
      MDL-39060-master

      Description

      In the file "moodle/backup/util/plan/base_task.class.php" on line 179,

      $this->setting = array();

      references the "setting" field of base_task, which is not referenced anywhere else. I would imagine that this is just a typo, and the field should be "settings", and thus the line should read,

      $this->settings = array();

        Attachments

        1. 1.PNG
          1.PNG
          95 kB
        2. MDL-39060.png
          MDL-39060.png
          74 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  17/May/18