Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Caching
    • Labels:
    • Rank:
      49185

      Description

      Looking at https://github.com/moodle/moodle/tree/master/cache#store I found "**" not correctly parsed as sublist. Doing a search into the code:

      $ git grep -e "^\*\* .*$" -- "*.txt" "*.md"
      cache/README.md:** Data guarantee - Data is guaranteed to exist in the cache once it is set there. It is never cleaned up to free space or because it has not been recently used.
      cache/README.md:** Multiple identifiers - Rather than a single string key, the parts that make up the key are passed as an array.
      cache/README.md:** Native TTL support - When required, the store supports native ttl and doesn't require the cache API to manage ttl of things given to the store.
      lib/phpmailer/changelog.txt:** NOTE: WE HAVE A NEW LANGUAGE VARIABLE FOR DIGITALLY SIGNED S/MIME EMAILS.
      lib/phpmailer/changelog.txt:** DO NOT USE THIS IN PRODUCTION OR LIVE PROJECTS
      lib/phpmailer/changelog.txt:** DO NOT USE THIS IN PRODUCTION OR LIVE PROJECTS
      theme/bootstrap/readme_moodle.txt:** If you want to make changes to the .css generated from these .less files then you
      

      (I know, this is really trivial and not fundamental

        Activity

        Hide
        Matteo Scaramuccia added a comment -

        Blushing for this peer reviewing request...

        Show
        Matteo Scaramuccia added a comment - Blushing for this peer reviewing request...
        Hide
        Sam Hemelryk added a comment -

        Thanks Matteo, putting this straight up for integration

        Show
        Sam Hemelryk added a comment - Thanks Matteo, putting this straight up for integration
        Hide
        Dan Poltawski added a comment -

        Integrated to master, thanks Matteo.

        Show
        Dan Poltawski added a comment - Integrated to master, thanks Matteo.
        Hide
        Dan Poltawski added a comment -

        Visually inspected the change and looks good

        Show
        Dan Poltawski added a comment - Visually inspected the change and looks good
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Your awesome contributions are now part of Moodle, your fav LMS out there.

        Closing this as fixed.

        Many thanks for all the hard work, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Your awesome contributions are now part of Moodle, your fav LMS out there. Closing this as fixed. Many thanks for all the hard work, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: