Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28443 Action logging improvements META
  3. MDL-39068

Config log sort by 'value' and 'old value' doesn't work in MSSQL

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Against ALL databases (this was known to be failing under mssql/sqlsrv & oracle drivers:

      1) Go to the admin -> report -> config changes report.
      2) Verify that ordering by "date", "first name" and "surname" continue working.
      3) TEST: Verify that ordering by "new value" and "original value" are working ok on. Up and down (ASC and DESC).

      That's all. Ciao

      Show
      Against ALL databases (this was known to be failing under mssql/sqlsrv & oracle drivers: 1) Go to the admin -> report -> config changes report. 2) Verify that ordering by "date", "first name" and "surname" continue working. 3) TEST: Verify that ordering by "new value" and "original value" are working ok on. Up and down (ASC and DESC). That's all. Ciao
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      http://localhost/report/configlog/index.php?sort=value&dir=DESC&page=0&perpage=30

      Returns database error:
      Debug info: The text, ntext, and image data types cannot be compared or sorted, except when using IS NULL or LIKE operator.
      SELECT TOP 30 u.id,u.picture,u.firstname,u.lastname,u.imagealt,u.email,
      cl.timemodified, cl.plugin, cl.name, cl.value, cl.oldvalue
      FROM mdl_config_log cl
      JOIN mdl_user u ON u.id = cl.userid
      ORDER BY cl.value DESC
      [array (
      )]
      Error code: dmlreadexception
      Stack trace:

      line 426 of \lib\dml\moodle_database.php: dml_read_exception thrown
      line 256 of \lib\dml\mssql_native_moodle_database.php: call to moodle_database->query_end()
      line 713 of \lib\dml\mssql_native_moodle_database.php: call to mssql_native_moodle_database->query_end()
      line 113 of \report\configlog\index.php: call to mssql_native_moodle_database->get_recordset_sql()

        Attachments

          Activity

            People

            Assignee:
            stronk7 Eloy Lafuente (stronk7)
            Reporter:
            valeriik Valerii Kuznetsov
            Integrator:
            Damyon Wiese
            Tester:
            Michael de Raadt
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Jake Dallimore, Jun Pataleta, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/May/13