Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39077

get_max_upload_sizes does not include option for 0 when $CFG->maxbytes is not set.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      1. execute phpunit tests
      1. Install a new moodle instance through the web interface
      2. Verify the setting for workshop maxbytes does not appear on the front page settings step
      1. Go to the settings page for a course
      2. Verify that one of the options for the course limit is "Site upload limit (XX)"
      3. Change the maxbytes setting for a course to 1MB
      4. Create a workshop and verify that the default for maxbytes is "Course upload limit (1MB)"
      1. upgrade moodle instance from 2.4
      2. search for "maxbytes" in settings and verify there are no invalid setting values (highlighted in red in standard theme)
      Show
      execute phpunit tests Install a new moodle instance through the web interface Verify the setting for workshop maxbytes does not appear on the front page settings step Go to the settings page for a course Verify that one of the options for the course limit is "Site upload limit (XX)" Change the maxbytes setting for a course to 1MB Create a workshop and verify that the default for maxbytes is "Course upload limit (1MB)" upgrade moodle instance from 2.4 search for "maxbytes" in settings and verify there are no invalid setting values (highlighted in red in standard theme)
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w17_MDL-39077_m25_sizes

      Description

      This causes the workshop module setting maxbytes to appear on the front page for a new install.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                skodak Petr Skoda
                Reporter:
                damyon Damyon Wiese
                Peer reviewer:
                Jason Fowler
                Integrator:
                Dan Poltawski
                Tester:
                Rajesh Taneja
                Participants:
                Component watchers:
                Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13