Moodle
  1. Moodle
  2. MDL-39080

"Navigation" and "Main menu" look different in formal_white

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Themes
    • Labels:
      None
    • Testing Instructions:
      Hide

      Choose formal_white as your current theme.
      Add some resources to the "Main menu" block.
      Display, on the same moodle page, the "Navigation" and "Main menu" block.
      They should have the same aspect.

      Show
      Choose formal_white as your current theme. Add some resources to the "Main menu" block. Display, on the same moodle page, the "Navigation" and "Main menu" block. They should have the same aspect.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39080_master

      Description

      Building a new moodle site I found that "Navigation" and "Main menu" look different even if they show the same content.
      I attached two screen shots explaining the issue and the expected solution. I hope you do not mind if the screen shots are mostly in Italian.

        Gliffy Diagrams

        1. expected.png
          45 kB
        2. problem.png
          45 kB

          Activity

          Hide
          Andrea Bicciolo added a comment -

          Looks good to me as per testing instructions. Sending to integration.

          Show
          Andrea Bicciolo added a comment - Looks good to me as per testing instructions. Sending to integration.
          Hide
          Dan Poltawski added a comment -

          Integrated to master, 24 and 23 - thanks!

          Show
          Dan Poltawski added a comment - Integrated to master, 24 and 23 - thanks!
          Hide
          David Monllaó added a comment -

          It passes, thanks.

          I've noticed than using the standard theme the icons are close to each other, but is only my opinion, feel free to open another issue if you think more work should be done in other themes

          Show
          David Monllaó added a comment - It passes, thanks. I've noticed than using the standard theme the icons are close to each other, but is only my opinion, feel free to open another issue if you think more work should be done in other themes
          Hide
          Dan Poltawski added a comment -

          Blooming Marvelous! It's time for a knees up - your changes are upstream!

          Thanks for making Moodle better!

          Toodle pip

          Show
          Dan Poltawski added a comment - Blooming Marvelous! It's time for a knees up - your changes are upstream! Thanks for making Moodle better! Toodle pip

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: