Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Workshop
    • Labels:
    • Testing Instructions:
      Hide

      As admin/teacher

      1. Within a course create new workshop.
      2. Fill in the form and save it.
      3. Under the "setup phase" column, select the 'edit assessment form'
        Make sure there is no setType error.
      1. Set the workshop to 'submission phase'
      2. As student, go the workshop module and select the 'submit your work' link under the 'submission phase' column.
      3. Select the 'start preparing your submission' button.
        Make sure there is no setType error.
      Show
      As admin/teacher Within a course create new workshop. Fill in the form and save it. Under the "setup phase" column, select the 'edit assessment form' Make sure there is no setType error. Set the workshop to 'submission phase' As student, go the workshop module and select the 'submit your work' link under the 'submission phase' column. Select the 'start preparing your submission' button. Make sure there is no setType error.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      49214

      Description

      Did you remember to call setType() for 'example'? Defaulting to PARAM_RAW cleaning.
      line 1289 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 158 of /mod/workshop/submission.php: call to moodleform->moodleform()
      

        Issue Links

          Activity

          Hide
          David Mudrak added a comment -

          Yupee. Thanks Rosie, sounds good to me. My +1 for submitting to integration.

          Show
          David Mudrak added a comment - Yupee. Thanks Rosie, sounds good to me. My +1 for submitting to integration.
          Hide
          Rossiani Wijaya added a comment -

          Thanks David for reviewing.

          Submitting for integration review.

          Show
          Rossiani Wijaya added a comment - Thanks David for reviewing. Submitting for integration review.
          Hide
          Dan Poltawski added a comment -

          Integrated to master - thanks Rosie

          Show
          Dan Poltawski added a comment - Integrated to master - thanks Rosie
          Hide
          Dan Poltawski added a comment -

          Tested during integration and passed

          Show
          Dan Poltawski added a comment - Tested during integration and passed
          Hide
          Dan Poltawski added a comment -

          Blooming Marvelous! It's time for a knees up - your changes are upstream!

          Thanks for making Moodle better!

          Toodle pip

          Show
          Dan Poltawski added a comment - Blooming Marvelous! It's time for a knees up - your changes are upstream! Thanks for making Moodle better! Toodle pip

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: