Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39085

Jump to menu centering clarification

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Not a bug
    • Affects Version/s: 2.5
    • Fix Version/s: None
    • Component/s: Course
    • Labels:
      None
    • Affected Branches:
      MOODLE_25_STABLE

      Description

      MDL-38907 removed the 'Jump to' menu centering that is used by MDL-34917, but did not remove the code:

      $select->class = 'jumpmenu';
      

      in '/course/format/renderer.php' that uses it.

      Aesthetically I think the text should be center aligned on the menu to bring symmetry with the left and right navigation facility and the css class be put back. Or if that is not desired, the redundant code removed. Or if this considered a theme style issue, that the base theme defines it such that core and contributed themes can choose to override it.

        Attachments

        1. MDL-39085_aesthetically_pleasing.png
          4 kB
          Gareth J Barnard
        2. MDL-39085_lop-sided.png
          4 kB
          Gareth J Barnard
        3. MDL-39085_redundant_selector_on_div.png
          28 kB
          Gareth J Barnard

          Issue Links

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              gb2048 Gareth J Barnard
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: