Moodle

No role name displayed after adding a course role user filter

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.4.3, 2.5
  • Fix Version/s: 2.4.4
  • Component/s: Administration
  • Labels:
  • Testing Instructions:
    Hide

    Test 1

    1. Go to admin -> users -> accounts -> browse list of users
    2. Add a "Student" course role filter
    3. You should see something like Course role is "Student" in any course from any category is displayed

    Test 2

    1. Go to admin -> users -> accounts -> browse list of users
    2. Add a "Course creator" system role filter
    3. You should see something like System role is "Course creator" is displayed
    Show
    Test 1 Go to admin -> users -> accounts -> browse list of users Add a "Student" course role filter You should see something like Course role is "Student" in any course from any category is displayed Test 2 Go to admin -> users -> accounts -> browse list of users Add a "Course creator" system role filter You should see something like System role is "Course creator" is displayed
  • Affected Branches:
    MOODLE_24_STABLE, MOODLE_25_STABLE
  • Fixed Branches:
    MOODLE_24_STABLE
  • Pull from Repository:
  • Pull 2.4 Branch:
    wip-mdl-39110-m24
  • Pull 2.4 Diff URL:
  • Pull Master Branch:
    wip-mdl-39110
  • Pull Master Diff URL:

Description

Steps to reproduce

  1. Go to admin -> users -> accounts -> browse list of users
  2. Add a "Student" course role filter
  3. Something like Course role is "" in "C1" from any category is displayed

Issue Links

discovered while testing

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-38617 Automate MDLQA-1178 - An administrator can filter user accounts by role, cohort and other variables

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
has a non-specific relationship to

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-38927 No role names in new role filer drop down menu in enrolled users page

  • Critical - Crashes server, loss of data, severe memory leak
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
is a regression caused by

Improvement - An enhancement to an existing Moodle feature. MDL-8249 Localised standard role names and descriptions

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Frédéric Massart added a comment -

Thanks Raj, this looks good to me. I confirmed that this does not apply to 2.3 as role_get_name() was introduced in MDL-8249 for 2.4. Pushing for integration.

Show
Frédéric Massart added a comment - Thanks Raj, this looks good to me. I confirmed that this does not apply to 2.3 as role_get_name() was introduced in MDL-8249 for 2.4. Pushing for integration.
Hide
Permalink
Dan Poltawski added a comment - - edited

Petr Škoda another regression from this role names thing

Show
Dan Poltawski added a comment - - edited Petr Škoda another regression from this role names thing
Hide
Permalink
Dan Poltawski added a comment -

Integrated to master and 24. Thanks Raj.

(BTW did we change something recently to notice all these, or we were just slack in 2.4 release??)

Show
Dan Poltawski added a comment - Integrated to master and 24. Thanks Raj. (BTW did we change something recently to notice all these, or we were just slack in 2.4 release??)
Hide
Permalink
Dan Poltawski added a comment -

Tested during integration and fixes the problem in both 2.4 and master. Thanks Raj

Show
Dan Poltawski added a comment - Tested during integration and fixes the problem in both 2.4 and master. Thanks Raj
Hide
Permalink
Dan Poltawski added a comment -

Blooming Marvelous! It's time for a knees up - your changes are upstream!

Thanks for making Moodle better!

Toodle pip

Show
Dan Poltawski added a comment - Blooming Marvelous! It's time for a knees up - your changes are upstream! Thanks for making Moodle better! Toodle pip

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: