Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39135

Warnings on bulk feedback file upload form

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.4.3, 2.5
    • Fix Version/s: 2.4.4
    • Component/s: Assignment
    • Labels:
      None

      Description

      1. Go to an assignment with submissions
        # In the grading form select one user and then 'with selected', 'Send feedback files'

      Warning: Missing argument 6 for assign_user_summary::__construct(), called in /Users/danp/moodles/pm/moodle/mod/assign/feedback/file/locallib.php on line 399 and defined in /Users/danp/moodles/pm/moodle/mod/assign/renderable.php on line 143
       
      Notice: Undefined variable: extrauserfields in /Users/danp/moodles/pm/moodle/mod/assign/renderable.php on line 149
       
      Warning: Invalid argument supplied for foreach() in /Users/danp/moodles/pm/moodle/mod/assign/renderer.php on line 142
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              poltawski Dan Poltawski added a comment -

              Up for review, thanks Damyon

              Show
              poltawski Dan Poltawski added a comment - Up for review, thanks Damyon
              Hide
              damyon Damyon Wiese added a comment -

              Thanks Dan,

              This needs backporting to 24 (only). I'll do that now.

              Show
              damyon Damyon Wiese added a comment - Thanks Dan, This needs backporting to 24 (only). I'll do that now.
              Hide
              damyon Damyon Wiese added a comment -

              Thanks for fixing this Dan, I just pushed your branch to my repo and added the backport.

              Looks good for integration.

              Show
              damyon Damyon Wiese added a comment - Thanks for fixing this Dan, I just pushed your branch to my repo and added the backport. Looks good for integration.
              Hide
              poltawski Dan Poltawski added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks guys, this has been integrated now.

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks guys, this has been integrated now.
              Hide
              ankit_frenz Ankit Agarwal added a comment -

              Works as described. passing.
              Thanks

              Show
              ankit_frenz Ankit Agarwal added a comment - Works as described. passing. Thanks
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              I feel myself really alone tonight! So was time to push your fixes upstream!

              "Lest we forget. We will remember them."

              Thanks and ciao!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - I feel myself really alone tonight! So was time to push your fixes upstream! "Lest we forget. We will remember them." Thanks and ciao!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/May/13