Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Resource
    • Labels:
    • Testing Instructions:
      Hide

      Debugging should be set to developer

      1. Create a new folder resource using the "Add an Activity or resource"
      2. Upload one file
      3. Click "Save and Display"
      4. When the folder resource is displayed click the "Edit" button.

      Verify no notices are displayed

      Show
      Debugging should be set to developer 1. Create a new folder resource using the "Add an Activity or resource" 2. Upload one file 3. Click "Save and Display" 4. When the folder resource is displayed click the "Edit" button. Verify no notices are displayed
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39140_m25
    • Rank:
      49737

      Description

      Found when testing MDLQA-5567:

      Did you remember to call setType() for 'id'? Defaulting to PARAM_RAW cleaning.
      line 1289 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 54 of /mod/folder/edit.php: call to moodleform->moodleform()

      Steps to reproduce:
      Create a new folder resource using the "Add an Activity or resource"
      Upload one file
      Click "Save and Display"
      When the folder resource is displayed click the "Edit" button.

      The notice will be displayed on the top of the page.

        Issue Links

          Activity

          Hide
          Ankit Agarwal added a comment -

          Hi Stephen,
          Thanks for working on the issue. The patch looks perfect. I grepd for other hidden/text/url elements with missing settypes in folder, there were none.

          Pushing for integration.
          Thanks

          Show
          Ankit Agarwal added a comment - Hi Stephen, Thanks for working on the issue. The patch looks perfect. I grepd for other hidden/text/url elements with missing settypes in folder, there were none. Pushing for integration. Thanks
          Hide
          Michael de Raadt added a comment -

          Thanks for working on that, Stephen.

          Show
          Michael de Raadt added a comment - Thanks for working on that, Stephen.
          Hide
          Dan Poltawski added a comment -

          Great - thanks Stephen - i've integrated this now

          Show
          Dan Poltawski added a comment - Great - thanks Stephen - i've integrated this now
          Hide
          Dan Poltawski added a comment -

          Tested during integration - thanks!

          Show
          Dan Poltawski added a comment - Tested during integration - thanks!
          Hide
          Dan Poltawski added a comment -

          Blooming Marvelous! It's time for a knees up - your changes are upstream!

          Thanks for making Moodle better!

          Toodle pip

          Show
          Dan Poltawski added a comment - Blooming Marvelous! It's time for a knees up - your changes are upstream! Thanks for making Moodle better! Toodle pip

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: