Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39148

Notices in plugins overview page after uninstalling selfcompletion block

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      Testing difficulty: medium (requires access to disk)

      1. Login as administrator and browse to Settings > Site administration > Plugins > Plugins overview.
      2. Click uninstall link next to any block (e.g. self_completion) and uninstall the block data. Do not remove the block folder from the disk.
      3. Return back to the plugins overview page
      4. TEST: Make sure there are no notices/warnings reported.
      5. TEST: Make sure there is no "Uninstall" link displayed for this to-be-installed block.
      6. TEST: Make sure the uninstalled block is now reported as "To be installed" and visiting the main administration page re-installs the block again.
      7. Rename, move or remove some block folder from the disk (e.g. rename "section_links" to ".section_links" or move it out of the $CFG->dirroot or remove it completely).
      8. Purge caches.
      9. Browse to Settings > Site administration > Plugins > Plugins overview.
      10. TEST: Make sure the block is reported as "Missing from disk".
      Show
      Testing difficulty: medium (requires access to disk) Login as administrator and browse to Settings > Site administration > Plugins > Plugins overview. Click uninstall link next to any block (e.g. self_completion) and uninstall the block data. Do not remove the block folder from the disk. Return back to the plugins overview page TEST: Make sure there are no notices/warnings reported. TEST: Make sure there is no "Uninstall" link displayed for this to-be-installed block. TEST: Make sure the uninstalled block is now reported as "To be installed" and visiting the main administration page re-installs the block again. Rename, move or remove some block folder from the disk (e.g. rename "section_links" to ".section_links" or move it out of the $CFG->dirroot or remove it completely). Purge caches. Browse to Settings > Site administration > Plugins > Plugins overview. TEST: Make sure the block is reported as "Missing from disk".
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39148-uninstall

      Description

      As reported by Séverin Terrier (https://tracker.moodle.org/browse/MDLQA-5428?focusedCommentId=215688&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-215688) after uninstalling selfcompletion block and accessing again to Site administration -> Plugins -> Plugins overview there is a couple of PHP notices.

      ( ! ) Notice: Undefined index: selfcompletion in /home/davidm/Desktop/moodlecode/INTEGRATION/master/lib/pluginlib.php on line 2684
      Call Stack
      #	Time	Memory	Function	Location
      1	0.0002	244368	{main}( )	../plugins.php:0
      2	0.8274	44382576	core_admin_renderer->plugin_management_page( )	../plugins.php:67
      3	0.9454	45082240	core_admin_renderer->plugins_control_panel( )	../renderer.php:368
      4	1.5291	55318632	plugininfo_block->get_uninstall_url( )	../renderer.php:1137
       
      ( ! ) Notice: Trying to get property of non-object in /home/davidm/Desktop/moodlecode/INTEGRATION/master/lib/pluginlib.php on line 2684
      Call Stack
      #	Time	Memory	Function	Location
      1	0.0002	244368	{main}( )	../plugins.php:0
      2	0.8274	44382576	core_admin_renderer->plugin_management_page( )	../plugins.php:67
      3	0.9454	45082240	core_admin_renderer->plugins_control_panel( )	../renderer.php:368
      4	1.5291	55318632	plugininfo_block->get_uninstall_url( )	../renderer.php:1137
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13