Moodle
  1. Moodle
  2. MDL-39167

Quiz access rule plugins cannot validate the settings

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3.6, 2.4.3
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide
      1. Install https://github.com/moodleou/moodle-quizaccess_safeexambrowser
      2. Create a new quiz.
      3. Type garbage into the new Allowed browser exam keys field.
      4. Try submitting the form, verify you get a validation error.
      5. Delete the allowed keys, but cause a validation error somewhere else. (E.g. enter a feedback boundary, but no feedback.) Make sure the validation still works.
      6. Fix the other validation problem, and enter a valid browser key (that is, any 64-bit hex string like 81aad4ab9dfd447cc479e6a4a7c9a544e2cafc7f3adeb68b2a21efad68eca4dc. Ensure you can save the form.
      Show
      Install https://github.com/moodleou/moodle-quizaccess_safeexambrowser Create a new quiz. Type garbage into the new Allowed browser exam keys field. Try submitting the form, verify you get a validation error. Delete the allowed keys, but cause a validation error somewhere else. (E.g. enter a feedback boundary, but no feedback.) Make sure the validation still works. Fix the other validation problem, and enter a valid browser key (that is, any 64-bit hex string like 81aad4ab9dfd447cc479e6a4a7c9a544e2cafc7f3adeb68b2a21efad68eca4dc. Ensure you can save the form.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull 2.4 Branch:
    • Pull Master Branch:
    • Rank:
      49768

      Description

      Can't think how I missed this, but it is an essential, and backwards compatible addition to the API.

        Activity

        Hide
        Tim Hunt added a comment -

        OK, submitting for integration.

        Show
        Tim Hunt added a comment - OK, submitting for integration.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Damyon Wiese added a comment -

        Thanks Tim,

        Considered if this was a bug or an improvement, but went with bug because it was 100% backwards compatible, safe and only allowing this for 2.5+ would be a PIA for contributed plugins.

        Integrated to 2.3, 2.4 and master branches.

        Show
        Damyon Wiese added a comment - Thanks Tim, Considered if this was a bug or an improvement, but went with bug because it was 100% backwards compatible, safe and only allowing this for 2.5+ would be a PIA for contributed plugins. Integrated to 2.3, 2.4 and master branches.
        Hide
        Tim Hunt added a comment -

        Thanks Damyon. (I thought I was pushing it by calling this a bug, but it is a blocker for something I am doing for another open source project - https://github.com/moodleou/moodle-quizaccess_safeexambrowser. Also it should have been there since this API was introduced in 2.2.)

        Show
        Tim Hunt added a comment - Thanks Damyon. (I thought I was pushing it by calling this a bug, but it is a blocker for something I am doing for another open source project - https://github.com/moodleou/moodle-quizaccess_safeexambrowser . Also it should have been there since this API was introduced in 2.2.)
        Hide
        Adrian Greeve added a comment -

        tested on the 23, 24 and master integration branches.
        Validation works.
        Test passed.

        Show
        Adrian Greeve added a comment - tested on the 23, 24 and master integration branches. Validation works. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        I feel myself really alone tonight! So was time to push your fixes upstream!

        "Lest we forget. We will remember them."

        Thanks and ciao!

        Show
        Eloy Lafuente (stronk7) added a comment - I feel myself really alone tonight! So was time to push your fixes upstream! "Lest we forget. We will remember them." Thanks and ciao!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: