Moodle
  1. Moodle
  2. MDL-39172

Import of .dat files is broken in blackboard_six import format

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.7, 2.4.4, 2.5
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Questions
    • Labels:
    • Rank:
      49774

      Description

      This is a regression from MDL-38388.
      Import of .zip archives is working as expected, but import of .dat files is broken.
      Notice: Undefined variable: text in C:\wamp\www\moodle_head\question\format\blackboard_six\format.php on line 81
      Call Stack

      1. Time Memory Function Location
        1 0.0028 743760 {main}( ) ..\import.php:0
        2 1.8617 82028992 qformat_default->importprocess( ) ..\import.php:119
        3 1.8620 82029176 qformat_blackboard_six->readdata( ) ..\format.php:298

        Notice: Undefined variable: text in C:\wamp\www\moodle_head\question\format\blackboard_six\format.php on line 84
        Call Stack
        # Time Memory Function Location
        1 0.0028 743760 {main}

        ( ) ..\import.php:0
        2 1.8617 82028992 qformat_default->importprocess( ) ..\import.php:119
        3 1.8620 82029176 qformat_blackboard_six->readdata( ) ..\format.php:298
        fileobj type not recognised

      line 182 of \question\format\blackboard_six\format.php: call to debugging()
      line 303 of \question\format.php: call to qformat_blackboard_six->readquestions()
      line 119 of \question\import.php: call to qformat_default->importprocess()

        Issue Links

          Activity

          Hide
          Jean-Michel Vedrine added a comment -

          Hello Tim, could you peer review this? If OK I will create other branchs

          Show
          Jean-Michel Vedrine added a comment - Hello Tim, could you peer review this? If OK I will create other branchs
          Hide
          Tim Hunt added a comment -

          That makes sense to me. If you have tested it, then you are good to back-port.

          Show
          Tim Hunt added a comment - That makes sense to me. If you have tested it, then you are good to back-port.
          Hide
          Jean-Michel Vedrine added a comment -

          Hello Tim,
          Rebased and cherry picked to stable branchs. I think this is ready for integration together with MDL-39164

          Show
          Jean-Michel Vedrine added a comment - Hello Tim, Rebased and cherry picked to stable branchs. I think this is ready for integration together with MDL-39164
          Hide
          Tim Hunt added a comment -

          Great. Thanks Jean-Michel. Submitting this for integration now.

          Show
          Tim Hunt added a comment - Great. Thanks Jean-Michel. Submitting this for integration now.
          Hide
          Sam Hemelryk added a comment -

          Thanks guys, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks guys, this has been integrated now
          Hide
          Rossiani Wijaya added a comment -

          This is working as expected.

          Tested for 2.3, 2.4 and master

          Test passed.

          Show
          Rossiani Wijaya added a comment - This is working as expected. Tested for 2.3, 2.4 and master Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I feel myself really alone tonight! So was time to push your fixes upstream!

          "Lest we forget. We will remember them."

          Thanks and ciao!

          Show
          Eloy Lafuente (stronk7) added a comment - I feel myself really alone tonight! So was time to push your fixes upstream! "Lest we forget. We will remember them." Thanks and ciao!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: